Skip to content

ref(tasks): Remove base64 encoding for bytes parameters in tasks#116293

Merged
untitaker merged 1 commit into
masterfrom
markusunterwaditzer/stream-1011-remove-base64-from-tasks
May 27, 2026
Merged

ref(tasks): Remove base64 encoding for bytes parameters in tasks#116293
untitaker merged 1 commit into
masterfrom
markusunterwaditzer/stream-1011-remove-base64-from-tasks

Conversation

@untitaker
Copy link
Copy Markdown
Member

@untitaker untitaker commented May 27, 2026

Summary

  • Pass bytes directly to tasks instead of base64-encoding, now that taskbroker uses msgpack
  • assemble_download: page_token now accepts bytes | str
  • fulfill_cross_region_export_request: encrypt_with_public_key now accepts bytes | str
  • Both handle legacy base64 strings for backwards compatibility

Follow-up to #115069 which did the same for process_profile_task.

ref STREAM-1011

Pass bytes directly to tasks instead of base64-encoding them, now that
taskbroker uses msgpack which supports bytes natively.

- assemble_download: page_token now accepts bytes | str
- fulfill_cross_region_export_request: encrypt_with_public_key now accepts bytes | str

Both tasks handle legacy base64 strings for backwards compatibility
during rollout.

ref STREAM-1011
@untitaker untitaker requested review from a team as code owners May 27, 2026 13:49
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 27, 2026

STREAM-1011

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 27, 2026
@untitaker untitaker requested a review from a team May 27, 2026 14:07
@untitaker untitaker merged commit ac317d3 into master May 27, 2026
64 checks passed
@untitaker untitaker deleted the markusunterwaditzer/stream-1011-remove-base64-from-tasks branch May 27, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants