ref(metrics): Metric detail action menu tweaks#116292
Open
nsdeschenes wants to merge 4 commits into
Open
Conversation
Replace the embedded boolean with a named metrics samples table source so callers can identify whether rows are rendered on the metrics page, trace waterfall, or issue details. Preserve the existing embedded table behavior while making the rendering context explicit. Refs LOGS-826
Show the Explore similar spans metric-name action only when samples are rendered in the trace waterfall. Keep metrics page and issue details samples to the default field actions, and cover those contexts in the metric panel tests. Refs LOGS-826
Add connected trace and Metrics Explore shortcuts for embedded metric sample rows. Suppress query-filtering cell actions on issue details where there is no visible metrics search bar. Refs LOGS-826 Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
Set the aggregate table cells to the metrics page source so the shared metrics table styling props remain type-safe after adding explicit sample table sources. Refs LOGS-826 Co-Authored-By: OpenAI Codex <noreply@openai.com>
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9c5474c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how the metric samples table renders based off of different sources. For the metrics page nothing has changed, however:
Closes LOGS-826
Examples:
Trace Waterfall:
Issue Detail:
