Skip to content

Draft: Type release health metrics_sessions_v2 and remove override #116284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Draft

Draft: Type release health metrics_sessions_v2 and remove override #116284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ module = [
"sentry.api.endpoints.organization_releases",
"sentry.db.postgres.base",
"sentry.middleware.ratelimit",
"sentry.release_health.metrics_sessions_v2",
"sentry.search.events.builder.errors",
"sentry.search.events.builder.metrics",
"sentry.search.events.datasets.filter_aliases",
Expand Down
9 changes: 7 additions & 2 deletions src/sentry/release_health/metrics_sessions_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@
MetricGroupByField,
MetricOrderByField,
)
from sentry.snuba.metrics.utils import OrderByNotSupportedOverCompositeEntityException
from sentry.snuba.metrics.utils import (
MetricOperationType,
OrderByNotSupportedOverCompositeEntityException,
)
from sentry.snuba.sessions_v2 import (
QueryDefinition,
finite_or_none,
Expand Down Expand Up @@ -302,8 +305,10 @@ def __init__(


class DurationField(Field):
op: MetricOperationType

def __init__(self, name: str, raw_groupby: Sequence[str], status_filter: StatusFilter):
self.op = name[:3] # That this works is just a lucky coincidence
self.op = cast(MetricOperationType, name.split("(", 1)[0])
super().__init__(name, raw_groupby, status_filter)

def _get_session_status(self, metric_field: MetricField) -> SessionStatus | None:
Expand Down
Loading