ref(utils): Small SafeRolloutComparator refactors#116257
Merged
lobsterkatie merged 3 commits intoMay 27, 2026
Merged
Conversation
markstory
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a few small changes to the
SafeRolloutComparatorcode.For the initial round of span-first detector testing, only the comparison part of the comparator is needed. This therefore splits the
checkpart ofcheck_and_chooseoff into its owncomparemethod.In cases where only the comparison is being used, it's not accurate to say that either the experimental or control data is being used. Therefore, "both" and "neither" have been added as allowable
source_of_truthtag values, to account for (as the names would suggest) both results being used or both results being discarded.Finally, now that it's part of the
comparemethod rather than thecheck_and_choosemethod, for new comparators theSafeRolloutComparator.check_and_choosemetric has been renamed toSafeRolloutComparator.compare. (The one existing comparator now has a flag which preserves the old behavior, so as not to break existing dashboards.)h/t Claude for his help with parts of these changes