feat(integrations): Log as warning when failed http.response#112665
Merged
feat(integrations): Log as warning when failed http.response#112665
Conversation
github-actions
bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
billyvg
approved these changes
Apr 13, 2026
Comment on lines
+117
to
+118
| log_level = self.logger.warning if error else self.logger.info | ||
| log_level("%s.http_response", self.integration_type, extra=log_params) |
Member
There was a problem hiding this comment.
logaf low: log_level makes me think it's the level itself (e.g. warning, info) rather than the logging fn.
wedamija
pushed a commit
that referenced
this pull request
Apr 13, 2026
Very minor change which makes looking to hundreds of logs a bit more obvious which ones did not get a 200 status code.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very minor change which makes looking to hundreds of logs a bit more obvious which ones did not get a 200 status code.