ref(cmdk): Remove onAction prop in favor of internal action execution#112648
Open
JonasBa wants to merge 2 commits intojb/cmdk/item-linksfrom
Open
ref(cmdk): Remove onAction prop in favor of internal action execution#112648JonasBa wants to merge 2 commits intojb/cmdk/item-linksfrom
JonasBa wants to merge 2 commits intojb/cmdk/item-linksfrom
Conversation
CommandPalette now handles all action execution internally — navigating for 'to' actions (with shift-key new-tab support) and invoking the action-defined onAction callback for callback actions. Callers no longer need to implement action dispatch logic; the only integration point is the optional closeModal prop. This removes the indirection of consumers inspecting CollectionTreeNode shapes at call sites and centralises the execution model inside the component. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
…Palette Both helpers were only used in commandPalette.tsx after the onAction removal. The separate module added indirection without reuse benefit, so inline the two functions and delete locationUtils.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the onAction prop from commandPalette which was requiring us to redefine the test and prod logic and diminishing the value of our tests. With this change, the action.onAction or action.to are invoked internally by the command palette.