chore(deps): bump lerna to ^9.0.7 to resolve remaining dev-tooling advisories#6499
Draft
antonis wants to merge 2 commits into
Draft
chore(deps): bump lerna to ^9.0.7 to resolve remaining dev-tooling advisories#6499antonis wants to merge 2 commits into
antonis wants to merge 2 commits into
Conversation
…isories Upgrades lerna 8.1.8 -> 9.0.7, which brings patched transitive @octokit/*, sigstore, @sigstore/core and uuid. lerna 9 pulls nx 22, which re-introduces a brace-expansion v5 DoS advisory; that is pinned to ^5.0.7 via resolutions. Removes two now-stale lerna@8.1.8 minimatch resolutions. All advisories are dev/build tooling only; the shipped @sentry/react-native runtime tree is unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Removes 5 scoped minimatch/js-yaml resolutions whose parent packages (front-matter@4.0.2, multimatch@5.0.0, node-dir@0.1.17, ignore-walk@6.0.5, nx@19.6.4) are no longer in the dependency tree after lerna 8 -> 9. Verified inert: yarn.lock is byte-identical after removal and yarn npm audit --recursive still reports 0 advisories. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9bebee+dirty | 3850.15 ms | 1227.51 ms | -2622.64 ms |
| 3d377b5+dirty | 1218.48 ms | 1219.51 ms | 1.03 ms |
| 1a2e7e0+dirty | 3842.49 ms | 1220.04 ms | -2622.45 ms |
| e5bb5f6+dirty | 3826.14 ms | 1212.24 ms | -2613.90 ms |
| 6acdf1d+dirty | 3844.33 ms | 1212.96 ms | -2631.38 ms |
| 41d6254+dirty | 3845.71 ms | 1224.51 ms | -2621.20 ms |
| 9210ae6+dirty | 3815.93 ms | 1214.14 ms | -2601.79 ms |
| c004dae+dirty | 3850.32 ms | 1227.79 ms | -2622.53 ms |
| 4e0b819+dirty | 3839.05 ms | 1210.75 ms | -2628.30 ms |
| 0b5120f+dirty | 3838.39 ms | 1232.91 ms | -2605.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9bebee+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 3d377b5+dirty | 3.38 MiB | 4.76 MiB | 1.38 MiB |
| 1a2e7e0+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| e5bb5f6+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 6acdf1d+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 41d6254+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| 9210ae6+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| c004dae+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 4e0b819+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| 0b5120f+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
antonis
marked this pull request as ready for review
July 22, 2026 11:37
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit adad396. Configure here.
| "downlevel-dts": "^0.11.0", | ||
| "google-java-format": "^1.4.0", | ||
| "lerna": "^8.1.8", | ||
| "lerna": "^9.0.7", |
There was a problem hiding this comment.
Lerna 9 drops Node 18
High Severity
Flagged because the dependency-update review guidelines call out new requirements from major bumps. lerna ^9.0.7 (and transitive nx 22) require Node ^20.19.0 || ^22.12.0 || >=24.0.0, but Volta still pins 18.20.8 and CI workflows still use node-version: 18. Build, test, and lerna version in release therefore run on an unsupported Node.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit adad396. Configure here.
Contributor
Author
There was a problem hiding this comment.
Marking as blocked for now since this is a valid concern that needs to be investigated in detail. All the issues that this PR fixes are dev only and do not affect production anyway.
antonis
marked this pull request as draft
July 22, 2026 11:42
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b0d3373+dirty | 3842.49 ms | 1218.49 ms | -2624.00 ms |
| ef27341+dirty | 3835.20 ms | 1212.23 ms | -2622.97 ms |
| e5bb5f6+dirty | 3825.74 ms | 1217.30 ms | -2608.43 ms |
| 44c8b3f+dirty | 3849.24 ms | 1209.94 ms | -2639.31 ms |
| 68672fc+dirty | 3832.22 ms | 1228.29 ms | -2603.93 ms |
| 5748023+dirty | 3844.74 ms | 1225.49 ms | -2619.26 ms |
| 6acdf1d+dirty | 3835.35 ms | 1218.30 ms | -2617.06 ms |
| 2c735cc+dirty | 1223.33 ms | 1224.38 ms | 1.04 ms |
| 100ce80+dirty | 3843.57 ms | 1226.46 ms | -2617.12 ms |
| 9210ae6+dirty | 3834.11 ms | 1216.64 ms | -2617.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b0d3373+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| ef27341+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| e5bb5f6+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 44c8b3f+dirty | 5.15 MiB | 6.66 MiB | 1.51 MiB |
| 68672fc+dirty | 5.15 MiB | 6.71 MiB | 1.55 MiB |
| 5748023+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 6acdf1d+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 2c735cc+dirty | 3.38 MiB | 4.74 MiB | 1.35 MiB |
| 100ce80+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 9210ae6+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
antonis
added
Blocked
and removed
ready-to-merge
Contributor
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 411.11 ms | 454.38 ms | 43.27 ms |
| d2eadf8+dirty | 414.64 ms | 454.56 ms | 39.92 ms |
| b0d3373+dirty | 557.66 ms | 579.42 ms | 21.76 ms |
| 27d9693+dirty | 419.08 ms | 469.12 ms | 50.04 ms |
| 4e0b819+dirty | 420.56 ms | 470.08 ms | 49.52 ms |
| 9474ead+dirty | 411.45 ms | 446.80 ms | 35.35 ms |
| 0bd8916+dirty | 412.77 ms | 451.31 ms | 38.54 ms |
| f9c1ed4+dirty | 431.00 ms | 466.22 ms | 35.22 ms |
| 3d536d1+dirty | 524.34 ms | 547.32 ms | 22.98 ms |
| 04207c4+dirty | 459.19 ms | 518.54 ms | 59.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| d2eadf8+dirty | 48.30 MiB | 53.48 MiB | 5.18 MiB |
| b0d3373+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| 27d9693+dirty | 49.74 MiB | 55.09 MiB | 5.34 MiB |
| 4e0b819+dirty | 49.74 MiB | 54.81 MiB | 5.07 MiB |
| 9474ead+dirty | 48.30 MiB | 53.61 MiB | 5.30 MiB |
| 0bd8916+dirty | 48.30 MiB | 53.57 MiB | 5.26 MiB |
| f9c1ed4+dirty | 49.74 MiB | 54.86 MiB | 5.12 MiB |
| 3d536d1+dirty | 49.74 MiB | 55.26 MiB | 5.52 MiB |
| 04207c4+dirty | 43.75 MiB | 48.12 MiB | 4.37 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Upgrades
lerna^8.1.8→^9.0.7to clear the remaining transitive security advisories that were bundled inside lerna 8's publish/GitHub-API internals.Changes:
lerna: ^8.1.8 → ^9.0.7(dev dependency).brace-expansionv5 to^5.0.7viaresolutions— lerna 9 pulls nx 22, which would otherwise re-introduce abrace-expansionDoS (see below).lerna@npm:8.1.8/@lerna/create@npm:8.1.8(those packages no longer exist in lerna 9).front-matter@4.0.2/js-yaml,multimatch@5.0.0/minimatch,node-dir@0.1.17/minimatch,ignore-walk@6.0.5/minimatch,nx@19.6.4/minimatch. Their parent packages are no longer in the tree after lerna 8 → 9; verified inert (yarn.lock byte-identical after removal, audit still 0).All affected packages are dev/build tooling only — none are part of the shipped
@sentry/react-nativeruntime, whose production dependency tree audits clean before and after this change.💡 Motivation and Context
Follow-up to the earlier dev-only advisory fixes (#6486, #6487, #6488, #6489). After those, the remaining open Dependabot alerts were all bundled inside
lerna@8.1.8. Bumping lerna to 9 resolves them all.Advisories resolved by this PR:
sigstore— GHSA-52v5-jr5w-gjxr (High)@sigstore/core— GHSA-jfc7-64v2-mr8c (Moderate)@octokit/plugin-paginate-rest— GHSA-h5c3-5r3r-rr8q (Moderate)@octokit/request— GHSA-rmvr-2pp2-xj38 (Moderate)@octokit/request-error— GHSA-xx4v-prfh-6cgc (Moderate)uuid— GHSA-w5hq-g745-h8pq (Moderate)Advisory introduced by nx 22 and pre-emptively pinned here:
brace-expansion(v5,>=3.0.0 <5.0.7) — GHSA-3jxr-9vmj-r5cp (High) → pinned to^5.0.7.After this PR,
yarn npm audit --recursivereports 0 real advisories (excluding unrelated deprecation notices).💚 How did you test it?
Run locally on this branch:
yarn install --immutable— passes (lockfile in sync, no unused-resolution warnings).yarn npm audit --recursive— 0 real advisories.yarn build— ✅ Successfully ranbuildfor all projects.yarn test— ✅ Successfully rantestfor all projects (all suites passing).📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Confirm the
lerna publish/ release workflow still works on lerna 9 before merging.