Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"babel-jest": "^29.7.0",
"jest": "^29.7.0",
"react": "18.3.1",
"react-native": "0.77.1",
"react-native": "0.85.1",
"react-native-launch-arguments": "^4.0.2",
"typescript": "4.9.5",
"webdriverio": "^8.27.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"oxlint": "^1.56.0",
"oxlint-tsgolint": "^0.17.4",
"react": "19.1.0",
"react-native": "0.80.1",
"react-native": "0.85.1",
"react-test-renderer": "19.1.0",
"rimraf": "^4.1.1",
"ts-jest": "^29.3.1",
Expand Down
2 changes: 1 addition & 1 deletion performance-tests/TestAppPlain/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"dependencies": {
"react": "19.1.0",
"react-native": "0.80.2"
"react-native": "0.85.1"

Check warning on line 12 in performance-tests/TestAppPlain/package.json

View check run for this annotation

@sentry/warden / warden: code-review

React Native dev dependencies not updated to match 0.85.1

The `react-native` package is updated to 0.85.1, but `@react-native/babel-preset`, `@react-native/metro-config`, and `@react-native/typescript-config` remain at 0.80.2 (lines 21-23). These packages are typically released in lockstep with the main react-native package and version mismatches can cause build failures or runtime errors due to incompatible Metro bundler or Babel transformations.

Check warning on line 12 in performance-tests/TestAppPlain/package.json

View check run for this annotation

@sentry/warden / warden: code-review

Node.js engine constraint incompatible with React Native 0.85.1

According to the PR changelog, React Native 0.84+ requires Node.js v22.11 minimum, but the `engines.node` field (line 32) still specifies `>=18`. This will allow CI/CD or developers to run builds with unsupported Node versions, potentially causing runtime errors or build failures.
},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
2 changes: 1 addition & 1 deletion performance-tests/TestAppSentry/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
"start": "react-native start"
},
"dependencies": {
"@react-native/new-app-screen": "0.80.2",
"@sentry/react-native": "8.8.0",
"react": "19.1.0",
"react-native": "0.80.2"
"react-native": "0.85.1"

Check warning on line 14 in performance-tests/TestAppSentry/package.json

View check run for this annotation

@sentry/warden / warden: code-review

[RDW-HG3] React Native dev dependencies not updated to match 0.85.1 (additional location)

The `react-native` package is updated to 0.85.1, but `@react-native/babel-preset`, `@react-native/metro-config`, and `@react-native/typescript-config` remain at 0.80.2 (lines 21-23). These packages are typically released in lockstep with the main react-native package and version mismatches can cause build failures or runtime errors due to incompatible Metro bundler or Babel transformations.

Check warning on line 14 in performance-tests/TestAppSentry/package.json

View check run for this annotation

@sentry/warden / warden: code-review

[7VP-75W] Node.js engine constraint incompatible with React Native 0.85.1 (additional location)

According to the PR changelog, React Native 0.84+ requires Node.js v22.11 minimum, but the `engines.node` field (line 32) still specifies `>=18`. This will allow CI/CD or developers to run builds with unsupported Node versions, potentially causing runtime errors or build failures.

Check warning on line 14 in performance-tests/TestAppSentry/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

[AZH-6MY] React Native dev dependencies pinned to 0.73.x while react-native is 0.85.1 (additional location)

The devDependencies `@react-native/babel-preset@0.73.21`, `@react-native/metro-config@0.73.5`, and `@react-native/typescript-config@0.73.1` are all pinned to 0.73.x versions while react-native is now 0.85.1. These @react-native/* packages are released in lockstep with react-native and should match the major.minor version. Using mismatched versions may cause build or transpilation issues.
Copy link
Copy Markdown

@sentry-warden sentry-warden bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js engine requirement incompatible with new React Native version

React Native 0.85.1 requires Node.js v22.11+ according to the changelog breaking changes, but the engines field specifies >=18. Users running Node.js versions 18-22.10 would get past the engines check but encounter runtime failures.

Verification

Confirmed by reviewing the PR description changelog which states: 'Bump minimum Node.js version to v22.11' as a breaking change in v0.84.0. The context after shows engines field at line 35-36 with "node": ">=18".

Also found at 1 additional location
  • performance-tests/TestAppPlain/package.json:12

Identified by Warden code-review, find-bugs · 6ER-FJB

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix attempt detected (commit b79b430)

The commit upgraded React Native to v0.85.1 which requires Node.js v22.11+, but the engines field was left unchanged at '>=18', failing to enforce the required Node.js minimum version.

The original issue appears unresolved. Please review and try again.

Evaluated by Warden

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix attempt detected (commit 6b115b3)

The commit updated React Native to v0.85.1 but failed to update the engines field from '>=18' to '>=22.11' to match the new version's Node.js requirements, leaving the incompatibility unresolved.

The original issue appears unresolved. Please review and try again.

Evaluated by Warden

},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
2 changes: 1 addition & 1 deletion samples/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"expo-web-browser": "~55.0.9",
"react": "19.2.0",
"react-dom": "19.2.0",
"react-native": "0.83.2",
"react-native": "0.85.1",
"react-native-gesture-handler": "~2.30.0",
"react-native-safe-area-context": "~5.6.0",
"react-native-screens": "~4.23.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native-macos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@sentry/react-native": "8.8.0",
"delay": "^6.0.0",
"react": "18.2.0",
"react-native": "0.73.9",
"react-native": "0.85.1",

Check failure on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: code-review

Version mismatch between react-native (0.85.1) and react-native-macos (0.73.34) will likely cause runtime errors

The `react-native` package is being updated to v0.85.1 while `react-native-macos` remains pinned at v0.73.34. The `react-native-macos` package is a fork that must be version-aligned with the core `react-native` package. This version disparity (12 minor versions apart) will likely cause API incompatibilities, missing bridging code, and runtime crashes when running on macOS.

Check warning on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: code-review

React Native devDependencies still reference v0.73.x, incompatible with v0.85.1

The devDependencies `@react-native/babel-preset` (0.73.21), `@react-native/metro-config` (0.73.5), and `@react-native/typescript-config` (0.73.1) are pinned to v0.73.x versions. These packages should be updated to match the new react-native v0.85.1 to ensure consistent build tooling, Metro bundler configuration, and TypeScript support.

Check failure on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

react-native-macos 0.73.34 is incompatible with react-native 0.85.1

The `react-native` is being updated from 0.73.9 to 0.85.1 but `react-native-macos` remains at 0.73.34. The react-native-macos library is a fork that tracks specific React Native versions - version 0.73.x is designed for react-native@0.73.x. This major version mismatch (0.73 vs 0.85) will cause build failures or runtime errors as the internal APIs have changed significantly between these versions.

Check warning on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

React Native dev dependencies pinned to 0.73.x while react-native is 0.85.1

The devDependencies `@react-native/babel-preset@0.73.21`, `@react-native/metro-config@0.73.5`, and `@react-native/typescript-config@0.73.1` are all pinned to 0.73.x versions while react-native is now 0.85.1. These @react-native/* packages are released in lockstep with react-native and should match the major.minor version. Using mismatched versions may cause build or transpilation issues.

Check warning on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

Node.js engine requirement not updated for React Native 0.85.1

The `engines` field specifies Node.js `>=18`, but according to the PR changelog, React Native v0.84.0 bumped the minimum Node.js version to v22.11. Running with Node.js versions between 18 and 22.10 may cause build or runtime failures that are difficult to diagnose.
"react-native-gesture-handler": "2.14.0",
"react-native-macos": "0.73.34",
"react-native-reanimated": "3.8.1",
Expand Down
Loading
Loading