Skip to content

fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle#6844

Open
alexander-alderman-webb wants to merge 16 commits into
webb/no-op-start-transactionfrom
webb/no-op-ctx-mgr
Open

fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle#6844
alexander-alderman-webb wants to merge 16 commits into
webb/no-op-start-transactionfrom
webb/no-op-ctx-mgr

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Do not set a transaction-based span on the scope when span streaming. The early returns in start_span() and start_transaction() are not sufficient as they return NoOpSpan when span streaming, and NoOpSpan still mutates scopes on __enter__() and __exit__().

Issues

Reminders

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

91914 passed | ⏭️ 6302 skipped | Total: 98216 | Pass Rate: 93.58% | Execution Time: 320m 34s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📈 +1
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_circular_references
    • File: tests.tracing.test_misc

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2485 uncovered lines.
❌ Project coverage is 89.65%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.68%    89.65%    -0.03%
==========================================
  Files          193       193         —
  Lines        24007     24013        +6
  Branches      8342      8346        +4
==========================================
+ Hits         21529     21528        -1
- Misses        2478      2485        +7
- Partials      1387      1387         —

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title fix(tracing): Stop setting NoOpSpan on scope fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle Jul 20, 2026
@alexander-alderman-webb
alexander-alderman-webb changed the base branch from master to webb/no-op-start-transaction July 21, 2026 13:10
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 21, 2026 14:46
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 21, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants