fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle#6844
Open
alexander-alderman-webb wants to merge 16 commits into
Open
fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle#6844alexander-alderman-webb wants to merge 16 commits into
NoOpSpan on scope in the streaming trace lifecycle#6844alexander-alderman-webb wants to merge 16 commits into
Conversation
Contributor
Codecov Results 📊✅ 91914 passed | ⏭️ 6302 skipped | Total: 98216 | Pass Rate: 93.58% | Execution Time: 320m 34s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2485 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.68% 89.65% -0.03%
==========================================
Files 193 193 —
Lines 24007 24013 +6
Branches 8342 8346 +4
==========================================
+ Hits 21529 21528 -1
- Misses 2478 2485 +7
- Partials 1387 1387 —Generated by Codecov Action |
NoOpSpan on scope in the streaming trace lifecycle
alexander-alderman-webb
changed the base branch from
master
to
webb/no-op-start-transaction
July 21, 2026 13:10
alexander-alderman-webb
marked this pull request as ready for review
July 21, 2026 14:46
sentrivana
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not set a transaction-based span on the scope when span streaming. The early returns in
start_span()andstart_transaction()are not sufficient as they returnNoOpSpanwhen span streaming, andNoOpSpanstill mutates scopes on__enter__()and__exit__().Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)