fix(native): resolve symbol names for crashed thread on Linux#1764
Merged
Conversation
Resolve function names from on-disk ELF symbol tables (.dynsym/.symtab) for the crashed thread's stacktrace in the crash daemon. The daemon already had module paths and base addresses from ctx->modules[], so symbol resolution is a straightforward ELF section header parse + symbol table lookup — no ptrace needed. Previously, the pre-captured backtrace (DWARF-based, signal-frame-aware) from the signal handler was preferred over remote unwinding for the crashed thread, but only set instruction_addr and module package — never function names. The FP-walking and single-IP fallback paths had the same gap.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4855289. Configure here.
mujacica
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve function names from on-disk ELF symbol tables (
.dynsym/.symtab) for the crashed thread's stacktrace in the crash daemon. The daemon already had module paths and base addresses fromctx->modules[], so symbol resolution is a straightforward ELF section header parse + symbol table lookup — no ptrace needed (which is not safe for the crashed thread).Previously, the pre-captured backtrace (DWARF-based, signal-frame-aware) from the signal handler was preferred over remote unwinding for the crashed thread, but only set
instruction_addrand module package — never function names. The FP-walking and single-IP fallback paths had the same gap.