fix(server-runtime-injection): Keep ES modules working on Deno - #24669
Merged
Merged
Conversation
JPeer264
added this pull request to stack #24670
September 23, 2026 16:19
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
from
September 23, 2026 16:40
055e26b to
540f4fe
Compare
JPeer264
removed this pull request from stack #24670
September 23, 2026 17:26
JPeer264
added this pull request to stack #24671
September 23, 2026 17:31
JPeer264
marked this pull request as ready for review
September 23, 2026 17:35
JPeer264
requested review from
andreiborza,
isaacs,
logaretm and
stephanie-anderson
and removed request for
a team,
logaretm and
stephanie-anderson
September 23, 2026 17:35
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
from
September 24, 2026 09:13
540f4fe to
c909f07
Compare
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
from
September 24, 2026 09:24
c909f07 to
29a2d60
Compare
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
from
September 24, 2026 14:05
29a2d60 to
12e0fce
Compare
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
2 times, most recently
from
September 25, 2026 15:41
3197ab3 to
65bccc8
Compare
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
from
September 25, 2026 15:49
65bccc8 to
0991af4
Compare
isaacs
approved these changes
Sep 25, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
This is straightforwardly correct. Closes the loop that we started with the JSON fix. TBH, I'm not sure why we didn't do that then. Oh well, probably thought we could get away without the added overhead.
Definitely add a comment to remove it in v12 (or 13 or whenever Deno ages out of needing it).
| * `'json'` or `'module'`. Without the format, Deno's CJS loader compiles JSON as JavaScript | ||
| * (`SyntaxError: Unexpected token ':'`), and the transform treats an ES module as CommonJS and | ||
| * injects a `require()` into it (`ReferenceError: require is not defined`). The format is restored | ||
| * on the `nextLoad` result, so the transform sees it too. Only Deno needs this. |
Member
There was a problem hiding this comment.
Worth adding a comment here and in the PR description as well, that it's only needed as long as we support Deno versions that do not have the fix in denoland/deno#36849.
We're already gating on the presence/lack of a format, so we don't need any version sniffing, I don't think. But it'd be nice to know when we can cut the fix out entirely, certainly not before v12.
Actually, come to think of it, could also add a // todo(v12): evaluate if this is still needed for supported Deno versions so we know to circle back.
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
2 times, most recently
from
September 27, 2026 13:47
e9f557c to
92a3e17
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+63
to
+72
| if (url.startsWith('file:') && url.endsWith('.js') && getPackageType(dirname(fileURLToPath(url))) === 'module') { | ||
| return 'module'; | ||
| } | ||
| return undefined; | ||
| } | ||
|
|
||
| /** | ||
| * Deno's `nextLoad` reports no `format` for a `.json` file, where Node reports `'json'`. With any | ||
| * load hook installed, Deno's CJS loader then compiles the JSON as JavaScript and `require()` of it | ||
| * throws `SyntaxError: Unexpected token ':'`. Restoring the format is enough, and only Deno needs | ||
| * it: on Node the format is never missing. | ||
| * Deno's `nextLoad` reports no `format` for a `.json` file or an ES module, where Node reports | ||
| * `'json'` or `'module'`. Without the format, Deno's CJS loader compiles JSON as JavaScript | ||
| * (`SyntaxError: Unexpected token ':'`), and the transform treats an ES module as CommonJS and |
Contributor
There was a problem hiding this comment.
Bug: The getPackageType function incorrectly caches undefined and fails to check parent directories if reading an existing package.json file fails.
Severity: LOW
Suggested Fix
When readFileSync fails within the try...catch block, the function should not cache undefined. Instead, it should fall back to checking the parent directory, similar to the logic used when existsSync returns false.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/server-runtime-injection/src/register.ts#L63-L72
Potential issue: The function `getPackageType` can incorrectly cache `undefined` for a
directory. This occurs if a `package.json` file exists but is unreadable (e.g., due to a
race condition or permissions issue). When `readFileSync` fails, the `catch` block sets
the module `type` to `undefined`. This `undefined` value is then cached for the
directory. The logic does not proceed to check parent directories for a `package.json`
file in this failure case, which can lead to incorrect module type resolution for
subsequent lookups in that directory.
Did we get this right? 👍 / 👎 to inform future reviews.
Deno's module hooks report no `format` for an ES module, so the orchestrion transform treated it as CommonJS and injected a `require()` that throws when the module loads. This broke `@sentry/node` on Deno for the ESM builds of libraries it instruments, such as the AI SDKs and `postgres`. The Deno load hook now restores the format of `.mjs` files and of `.js` files in a `"type": "module"` package, the same way it already did for JSON. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/node-suites-deno-esm-fix
branch
from
September 27, 2026 14:57
92a3e17 to
6248b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
deno run --preload=npm:@sentry/deno/import, an instrumented library that ships an ES module build crashed on import withReferenceError: require is not defined. Deno's module hooks report noformatfor an ES module, so the orchestrion transform treated it as CommonJS and injected arequire()into it. This hit the ESM builds of the AI SDKs andpostgres, among others.The Deno load hook now restores the format of
.mjsfiles and of.jsfiles in a"type": "module"package, the same way it already did for JSON (#24412). It restores it on thenextLoadresult, because the transform reads the format there.Running the shared Node integration suites on Deno found this. The next PR in the stack runs them in CI; the Deno-only orchestrion suites did not catch it because they publish fake channel messages instead of loading the real libraries.
Part of #24052 and #23897.
🤖 Generated with Claude Code