test(e2e): Add a sveltekit-2-otlp E2E app - #24184
Draft
chargome wants to merge 3 commits into
Draft
Conversation
…y setups Mirrors the nextjs-otlp app: the app registers its own OpenTelemetry tracer and meter providers, Sentry runs with enableOpenTelemetrySetup disabled, and the specs assert that errors, logs and metrics link to the active OpenTelemetry trace while spans and metrics keep exporting over OTLP.
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
The server entry lists Node SDK exports explicitly because some Vite production builds put star-export bindings on the default export. openTelemetryIntegration and getOtlpTracesEndpoint were only reachable via the star export, so they now join the explicit list.
The app no longer registers an OpenTelemetry meter provider or exports metrics over OTLP. Metrics, like logs, go through Sentry and are asserted to carry the active OpenTelemetry trace.
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b70b88b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a SvelteKit 2 E2E app mirroring nextjs-otlp, where the app owns the OpenTelemetry setup and the specs assert that errors, logs and metrics link to the active OpenTelemetry trace while spans and metrics keep exporting over OTLP.