fix(v10/cloudflare): Auto-instrument classes re-exported from the worker entry - #24181
Draft
JPeer264 wants to merge 1 commit into
Draft
fix(v10/cloudflare): Auto-instrument classes re-exported from the worker entry#24181JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
…ker entry Backport of: #23282
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #23282
Differences to the original PR
packages/cloudflare/test/vite/autoInstrument.test.ts: the three new agent re-export expectations includeenableRpcTracePropagation: opts?.enableRpcTracePropagation ?? true,in the generated__SENTRY_OPTIONS__snippet. v10 still emits that property, develop does not, so the strings had to match the v10 output (identical to the existing expectation in the same file).packages/cloudflare/src/durableobject.ts,packages/cloudflare/src/workflows.ts: theInstrumentedClass+markAsInstrumentedchange was applied on top of the v10 generic signatures. v10 does not have theDefaultEnv/ResolveEnv/StrictCloudflareOptionsgenerics refactor, so those signatures stay as they are on v10; the behavior change is the same.dev-packages/cloudflare-integration-tests/runner.ts:receivedEnvelopes.push(envelope)was added next to the v10 wording of the surrounding waiter comment.The behavior of the fix is unchanged, all deviations are adaptations to the older code shape.