test(e2e): Port the Vue TanStack Router E2E app to span streaming - #24170
Draft
RulaKhaled wants to merge 1 commit into
Draft
test(e2e): Port the Vue TanStack Router E2E app to span streaming#24170RulaKhaled wants to merge 1 commit into
RulaKhaled wants to merge 1 commit into
Conversation
Web vitals stay off the streamed pageload span, so that assertion is dropped. Redirect and follow-up navigation specs still match the parameterized target route. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin from the Vue TanStack Router E2E app and rewrites the routing specs onto streamed spans.Why
Web vitals
measurementslive on transaction events, not streamed spans, so those asserts are dropped rather than rewritten. Route names stay/posts/$postId; the Vue SDK still usesurl.path.parameter.postId.Part of #23805