fix(v10/react-router): Preserve sourcemaps.disable when unstable_sentryVitePluginOptions is set - #22966
Merged
Merged
Conversation
…entryVitePluginOptions` is set Backport of: #22945
Contributor
size-limit report 📦
|
…ourcemaps.disable `unstable_sentryVitePluginOptions` is documented as being able to override any option the SDK passes to the bundler plugin, and nuxt, sveltekit and nextjs all implement it that way. `sentryOnBuildEnd` was the one place that resolved `sourcemaps.disable` the other way round, giving the top-level option precedence. Note this only affects the buildEnd hook, where two user-supplied values genuinely conflict. The Vite plugin still pins `disable: true` unconditionally - that is an architectural invariant rather than a precedence decision, since the plugin injecting debug IDs on top of this hook is what breaks source map resolution. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
marked this pull request as ready for review
August 3, 2026 15:51
chargome
requested review from
Lms24,
nicohrubec and
s1gr1d
and removed request for
a team
August 3, 2026 15:51
nicohrubec
approved these changes
Aug 3, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #22945
Also flips
sourcemaps.disableprecedence insentryOnBuildEndsounstable_sentryVitePluginOptionswins. This is not part of #22945 as the unstable options will likely disappear there anyway.