Skip to content

chore(react): Replace unused eslint plugins with oxlint react rules - #22944

Merged
Lms24 merged 1 commit into
developfrom
chore/oxlint-react-hooks-rules
Aug 3, 2026
Merged

chore(react): Replace unused eslint plugins with oxlint react rules#22944
Lms24 merged 1 commit into
developfrom
chore/oxlint-react-hooks-rules

Conversation

@Lms24

@Lms24 Lms24 commented Aug 3, 2026

Copy link
Copy Markdown
Member

This PR:

  • deletes the unused eslint-plugin-react-hooks and eslint-plugin-react dev dependencies from React and NextJS packages. These were unused since we migrated to oxlint (raised via chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.2 to 7.1.1 #22151)
  • instead, the rules are already covered by oxlint
  • ensures we still error on a few react rule violations like we did in eslint times

Since the oxlint migration removed the eslint configs, eslint-plugin-react
and eslint-plugin-react-hooks in packages/react were declared but never
loaded by any linter, and packages/nextjs never enabled the react presets
even before the migration. Drop both dev dependencies.

The hooks coverage they used to provide is not lost: oxlint's react plugin
implements the same rules, and exhaustive-deps was already running in
packages/react as a non-failing warning. Promote rules-of-hooks,
exhaustive-deps and display-name to errors there, and enable the react
plugin in packages/nextjs so future client-side JSX is covered.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 29.91 kB - -
@sentry/browser - with treeshaking flags 28.11 kB - -
@sentry/browser (incl. Tracing) 47.35 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.36 kB - -
@sentry/browser (incl. Tracing, Profiling) 52.13 kB - -
@sentry/browser (incl. Tracing, Replay) 86.69 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.13 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.41 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 104.05 kB - -
@sentry/browser (incl. Feedback) 47.22 kB - -
@sentry/browser (incl. sendFeedback) 34.76 kB - -
@sentry/browser (incl. FeedbackAsync) 39.86 kB - -
@sentry/browser (incl. Metrics) 30.99 kB - -
@sentry/browser (incl. Logs) 31.22 kB - -
@sentry/browser (incl. Metrics & Logs) 31.89 kB - -
@sentry/react 31.73 kB - -
@sentry/react (incl. Tracing) 49.61 kB - -
@sentry/vue 34.98 kB - -
@sentry/vue (incl. Tracing) 49.34 kB - -
@sentry/svelte 29.94 kB - -
CDN Bundle 31.98 kB - -
CDN Bundle (incl. Tracing) 47.72 kB - -
CDN Bundle (incl. Logs, Metrics) 33.55 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.07 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.9 kB - -
CDN Bundle (incl. Tracing, Replay) 85.34 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.64 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.13 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.44 kB - -
CDN Bundle - uncompressed 95.49 kB - -
CDN Bundle (incl. Tracing) - uncompressed 143.08 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.2 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 147.06 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.96 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 262.34 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.3 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.04 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280 kB - -
@sentry/nextjs (client) 52.2 kB - -
@sentry/sveltekit (client) 47.8 kB - -
@sentry/core/server 80 kB - -
@sentry/core/browser 51.96 kB - -
@sentry/node 121.89 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 85.36 kB -0.01% -2 B 🔽
@sentry/aws-serverless 94.01 kB - -
@sentry/cloudflare (withSentry) - minified 199.28 kB - -
@sentry/cloudflare (withSentry) 490.77 kB - -

View base workflow run

@Lms24
Lms24 requested review from chargome and logaretm August 3, 2026 11:39
@Lms24
Lms24 marked this pull request as ready for review August 3, 2026 11:39
@Lms24
Lms24 requested a review from a team as a code owner August 3, 2026 11:39
@Lms24
Lms24 requested review from s1gr1d and removed request for a team August 3, 2026 11:39
@Lms24 Lms24 self-assigned this Aug 3, 2026
@Lms24
Lms24 merged commit 8884ca4 into develop Aug 3, 2026
266 of 267 checks passed
@Lms24
Lms24 deleted the chore/oxlint-react-hooks-rules branch August 3, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants