feat(node)!: Stop inferring name for spans - #22712
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 920920a. Configure here.
mydea
marked this pull request as ready for review
July 29, 2026 06:37
mydea
requested review from
andreiborza,
isaacs,
nicohrubec and
s1gr1d
and removed request for
a team
July 29, 2026 06:37
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
andreiborza
reviewed
Jul 29, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Could we add a bugbot rule to call out that we might need to re-set source after calling span.updateName?
Also, do we still need this function? 🤔
sentry-javascript/packages/core/src/utils/spanUtils.ts
Lines 460 to 482 in 9c8bc95
Comment on lines
19
to
21
| const ATTR_DB_MONGODB_COLLECTION = 'db.mongodb.collection'; | ||
| const ATTR_DB_CONNECTION_STRING = 'db.connection_string'; | ||
| const ATTR_NET_PEER_NAME = 'net.peer.name'; | ||
| const ATTR_NET_PEER_PORT = 'net.peer.port'; | ||
| const DB_SYSTEM_VALUE_MONGODB = 'mongodb'; |
Member
There was a problem hiding this comment.
q: Can we add these to sentry conventions?
Member
Author
There was a problem hiding this comment.
probably should revisit these generally, yes!
chargome
reviewed
Jul 29, 2026
JPeer264
reviewed
Jul 29, 2026
|
|
||
| const tediousSpan = parent.spans?.find(s => s.op === 'db'); | ||
| assertExists(tediousSpan, `expected a db child span, got ops: ${parent.spans?.map(s => s.op).join(', ')}`); | ||
| assertEquals(tediousSpan!.description, 'execSql mydb'); |
Member
There was a problem hiding this comment.
l/m: IIRC descriptions should be low cardinality and be sanitized. So the output should be SELECT ? in this case.
Member
Author
There was a problem hiding this comment.
this is fine because 1 is static - this is just the content of DB_STATEMENT!
Member
Author
yes, good idea!
not really, we can probably deprecate this for the v11 cycle then. |
chargome
approved these changes
Jul 29, 2026
more fixes moar fixes fixxx
mydea
added a commit
that referenced
this pull request
Jul 29, 2026
…22797) Stacked on top of #22712. With the span name/source inference reworked in #22712, core's `getDynamicSamplingContext` now derives the DSC transaction name from the root span and applies the `url` source guard itself. That makes the OpenTelemetry-specific `createDsc` handler `enhanceDscWithOpenTelemetryRootSpanName` redundant — it was only there to re-derive the name/source via `parseSpanDescription` before core did so natively. This removes the util along with its call sites in `@sentry/node`, `@sentry/vercel-edge`, and the opentelemetry test helper, and drops it from the package's public exports. Since the enhancer is a public export of `@sentry/opentelemetry`, its removal is technically breaking for anyone importing it directly — which is why this targets the breaking-change branch #22712. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, we make sure to properly set the name directly whenever we start spans.