feat(nextjs)!: Use middleware span op for Next.js middleware - #22674
Merged
Conversation
Member
Author
|
curslinger run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6180813. Configure here.
Contributor
size-limit report 📦
|
Aligns the Next.js middleware span op with the `@sentry/conventions` `WEB_SERVER_MIDDLEWARE_SPAN_OP` (`middleware`), replacing the previous `http.server.middleware`. The mixed `http.server`-family op was problematic for span streaming and description inference. Also adds regression coverage asserting the middleware wrapper does not start its own span (the duplicate was already removed in #18456). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
feat/nextjs-middleware-span-op
branch
from
July 27, 2026 12:07
1e77052 to
b769481
Compare
chargome
marked this pull request as ready for review
July 27, 2026 12:23
chargome
requested review from
Lms24,
nicohrubec and
s1gr1d
and removed request for
a team
July 27, 2026 12:23
Lms24
approved these changes
Jul 27, 2026
chargome
added a commit
that referenced
this pull request
Jul 27, 2026
Discovered in #22674 that this was not running on webpack so here we go. I added a reusable helper to aggregate streamed spans for e2e tests Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the Next.js middleware span op with the
@sentry/conventionsmiddleware, replacing the previoushttp.server.middleware.The duplicate middleware span this issue also described was already resolved separately in #18456 (the build-time wrapper no longer starts its own span); this PR adds the regression test coverage that was missing there.
closes #22636