feat(angular)!: Use ui.mount and function span ops for tracing decorators - #22667
Merged
Conversation
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/js-3105-gcp-grpc-op
branch
from
July 27, 2026 11:44
a8f5b90 to
789a8ef
Compare
msonnb
force-pushed
the
ms/js-3105-angular-ops
branch
from
July 27, 2026 11:44
de8350a to
7ac0b5d
Compare
msonnb
force-pushed
the
ms/js-3105-gcp-grpc-op
branch
from
July 27, 2026 12:10
789a8ef to
1d58df1
Compare
msonnb
force-pushed
the
ms/js-3105-angular-ops
branch
from
July 27, 2026 12:10
7ac0b5d to
6c7646e
Compare
msonnb
force-pushed
the
ms/js-3105-angular-ops
branch
from
July 27, 2026 13:50
6c7646e to
60666e6
Compare
…corators `TraceDirective`/`TraceClass` emit `ui.mount`; `TraceMethod` emits `function` with the method name in `code.function.name`. The method-key suffix was user-controlled and unbounded. Ref: JS-3105 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
msonnb
force-pushed
the
ms/js-3105-angular-ops
branch
from
July 28, 2026 13:45
60666e6 to
9643fa2
Compare
msonnb
marked this pull request as ready for review
July 28, 2026 14:03
msonnb
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
July 28, 2026 14:03
Lms24
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TraceDirectiveandTraceClassnow emitui.mountinstead ofui.angular.init.TraceMethodemitsfunctioninstead ofui.angular.<methodName>— the suffix was user-controlled and unbounded — with the method name preserved incode.function.name.Note
ui.mountis not in the conventions registry yet (tracked as its own row in the first table of the issue), so it is a literal here with a TODO to swap in the constant once registered.Part of #22446