Skip to content

feat(google-cloud-serverless)!: Use grpc span op for GCP gRPC calls - #22666

Merged
msonnb merged 3 commits into
developfrom
ms/js-3105-gcp-grpc-op
Jul 28, 2026
Merged

feat(google-cloud-serverless)!: Use grpc span op for GCP gRPC calls#22666
msonnb merged 3 commits into
developfrom
ms/js-3105-gcp-grpc-op

Conversation

@msonnb

@msonnb msonnb commented Jul 27, 2026

Copy link
Copy Markdown
Member

Use grpc instead of grpc.<service> in googleCloudGrpcIntegration. The service is now identified by the new rpc.service attribute. Also added rpc.system.name and rpc.method.

Part of #22446

@linear-code

linear-code Bot commented Jul 27, 2026

Copy link
Copy Markdown

JS-3105

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.85 kB - -
@sentry/browser - with treeshaking flags 28.06 kB - -
@sentry/browser (incl. Tracing) 47.42 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.43 kB - -
@sentry/browser (incl. Tracing, Profiling) 52.16 kB - -
@sentry/browser (incl. Tracing, Replay) 86.75 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.16 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.49 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 104.12 kB - -
@sentry/browser (incl. Feedback) 47.17 kB - -
@sentry/browser (incl. sendFeedback) 34.69 kB - -
@sentry/browser (incl. FeedbackAsync) 39.78 kB - -
@sentry/browser (incl. Metrics) 30.92 kB - -
@sentry/browser (incl. Logs) 31.15 kB - -
@sentry/browser (incl. Metrics & Logs) 31.83 kB - -
@sentry/react 31.64 kB - -
@sentry/react (incl. Tracing) 49.64 kB - -
@sentry/vue 34.77 kB - -
@sentry/vue (incl. Tracing) 49.38 kB - -
@sentry/svelte 29.88 kB - -
CDN Bundle 31.89 kB - -
CDN Bundle (incl. Tracing) 47.77 kB - -
CDN Bundle (incl. Logs, Metrics) 33.44 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.15 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.8 kB - -
CDN Bundle (incl. Tracing, Replay) 85.41 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.69 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.18 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.48 kB - -
CDN Bundle - uncompressed 95.14 kB - -
CDN Bundle (incl. Tracing) - uncompressed 143.28 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.85 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 147.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.61 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 262.54 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.5 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280.2 kB - -
@sentry/nextjs (client) 52.23 kB - -
@sentry/sveltekit (client) 47.84 kB - -
@sentry/core/server 79.73 kB - -
@sentry/core/browser 51.61 kB - -
@sentry/node 122.35 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B - -
@sentry/node - without tracing 85.76 kB - -
@sentry/aws-serverless 93.78 kB -0.01% -1 B 🔽
@sentry/cloudflare (withSentry) - minified 197.26 kB - -
@sentry/cloudflare (withSentry) 485.29 kB - -

View base workflow run

@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from 8390913 to b39334a Compare July 27, 2026 11:44
@msonnb
msonnb force-pushed the ms/js-3105-gcp-grpc-op branch from a8f5b90 to 789a8ef Compare July 27, 2026 11:44
@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from b39334a to 4b43c39 Compare July 27, 2026 12:10
@msonnb
msonnb force-pushed the ms/js-3105-gcp-grpc-op branch from 789a8ef to 1d58df1 Compare July 27, 2026 12:10
@msonnb
msonnb changed the base branch from ms/js-3105-cloudflare-queue-op to develop July 27, 2026 13:09
@msonnb
msonnb force-pushed the ms/js-3105-gcp-grpc-op branch 2 times, most recently from d2f3444 to 0078079 Compare July 27, 2026 15:13
msonnb and others added 2 commits July 28, 2026 14:23
The service suffix fragmented grouping and was unbounded for non-
`googleapis.com` service paths. Service identity moves to `rpc.service`,
with `rpc.system.name` and `rpc.method` added alongside.

Ref: JS-3105

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@msonnb
msonnb force-pushed the ms/js-3105-gcp-grpc-op branch from 0078079 to 1af70d9 Compare July 28, 2026 12:24
@msonnb
msonnb marked this pull request as ready for review July 28, 2026 12:42
@msonnb
msonnb requested a review from a team as a code owner July 28, 2026 12:42
@msonnb
msonnb requested review from isaacs and mydea and removed request for a team July 28, 2026 12:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2460c36. Configure here.

@msonnb
msonnb merged commit c735661 into develop Jul 28, 2026
43 checks passed
@msonnb
msonnb deleted the ms/js-3105-gcp-grpc-op branch July 28, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants