Skip to content

fix(cloudflare): Remove conflicting faas.queue op on queue consumer spans - #22664

Merged
msonnb merged 3 commits into
developfrom
ms/js-3105-cloudflare-queue-op
Jul 28, 2026
Merged

fix(cloudflare): Remove conflicting faas.queue op on queue consumer spans#22664
msonnb merged 3 commits into
developfrom
ms/js-3105-cloudflare-queue-op

Conversation

@msonnb

@msonnb msonnb commented Jul 27, 2026

Copy link
Copy Markdown
Member

The queue consumer span passed both op: 'faas.queue' and a sentry.op attribute of queue.process. The attribute wins, so faas.queue was dead. Emitted spans are unchanged.

Part of #22446

@linear-code

linear-code Bot commented Jul 27, 2026

Copy link
Copy Markdown

JS-3105

@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from 5bb54da to 8390913 Compare July 27, 2026 09:03
@github-actions

github-actions Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 29.85 kB - -
@sentry/browser - with treeshaking flags 28.06 kB - -
@sentry/browser (incl. Tracing) 47.42 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.43 kB - -
@sentry/browser (incl. Tracing, Profiling) 52.16 kB - -
@sentry/browser (incl. Tracing, Replay) 86.75 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.16 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.49 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 104.12 kB - -
@sentry/browser (incl. Feedback) 47.17 kB - -
@sentry/browser (incl. sendFeedback) 34.69 kB - -
@sentry/browser (incl. FeedbackAsync) 39.78 kB - -
@sentry/browser (incl. Metrics) 30.92 kB - -
@sentry/browser (incl. Logs) 31.15 kB - -
@sentry/browser (incl. Metrics & Logs) 31.83 kB - -
@sentry/react 31.64 kB - -
@sentry/react (incl. Tracing) 49.64 kB - -
@sentry/vue 34.77 kB - -
@sentry/vue (incl. Tracing) 49.38 kB - -
@sentry/svelte 29.88 kB - -
CDN Bundle 31.89 kB - -
CDN Bundle (incl. Tracing) 47.77 kB - -
CDN Bundle (incl. Logs, Metrics) 33.44 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.15 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.8 kB - -
CDN Bundle (incl. Tracing, Replay) 85.41 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.69 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.18 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.48 kB - -
CDN Bundle - uncompressed 95.14 kB - -
CDN Bundle (incl. Tracing) - uncompressed 143.28 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.85 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 147.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.61 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 262.54 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.5 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280.2 kB - -
@sentry/nextjs (client) 52.23 kB - -
@sentry/sveltekit (client) 47.84 kB - -
@sentry/core/server 79.73 kB - -
@sentry/core/browser 51.61 kB - -
@sentry/node 125.41 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B - -
@sentry/node - without tracing 85.76 kB - -
@sentry/aws-serverless 93.78 kB -0.01% -1 B 🔽
@sentry/cloudflare (withSentry) - minified 197.27 kB +0.01% +14 B 🔺
@sentry/cloudflare (withSentry) 485.32 kB +0.01% +30 B 🔺

View base workflow run

@msonnb
msonnb force-pushed the ms/js-3105-http-prefetch-op branch from a1fb45b to 07f72bb Compare July 27, 2026 11:44
@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from 8390913 to b39334a Compare July 27, 2026 11:44
@msonnb
msonnb force-pushed the ms/js-3105-http-prefetch-op branch from 07f72bb to 356902a Compare July 27, 2026 12:10
@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from b39334a to 4b43c39 Compare July 27, 2026 12:10
@msonnb
msonnb changed the base branch from ms/js-3105-http-prefetch-op to develop July 27, 2026 13:09
@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from 4b43c39 to f0a0c62 Compare July 27, 2026 13:50
msonnb and others added 2 commits July 28, 2026 13:51
@msonnb @claude
fix(cloudflare): Remove conflicting faas.queue op on queue consumer…
2380a3e 
… spans

The span passed both `op: 'faas.queue'` and a `sentry.op` attribute of
`queue.process`. The attribute wins, so `faas.queue` was dead. Emitted
spans are unchanged.

Ref: JS-3105

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@msonnb
use sentry.op
6331d6b
@msonnb
msonnb force-pushed the ms/js-3105-cloudflare-queue-op branch from f0a0c62 to 6331d6b Compare July 28, 2026 11:52
@msonnb
msonnb marked this pull request as ready for review July 28, 2026 12:21
@msonnb
msonnb requested a review from a team as a code owner July 28, 2026 12:21
@msonnb
msonnb requested review from andreiborza and isaacs and removed request for a team July 28, 2026 12:21
@msonnb
msonnb merged commit 988386e into develop Jul 28, 2026
81 checks passed
@msonnb
msonnb deleted the ms/js-3105-cloudflare-queue-op branch July 28, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreiborza andreiborza andreiborza approved these changes
@isaacs isaacs Awaiting requested review from isaacs isaacs is a code owner automatically assigned from getsentry/team-javascript-sdks-server

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msonnb @andreiborza