feat(react-router): Capture server build in dev mode for middleware names#22628
Closed
chargome wants to merge 1 commit into
Closed
feat(react-router): Capture server build in dev mode for middleware names#22628chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
…ames Gate the server build capture Vite plugin on the transform hook's `options.ssr` flag instead of `config.build.ssr`. `options.ssr` is set for the SSR module in both `react-router dev` and production builds, so middleware names now resolve in dev mode too (previously the build-only gate skipped dev entirely). Adds a dev-mode e2e app (`react-router-7-framework-instrumentation-dev`) that runs `react-router dev` and asserts the middleware name resolves from the captured server build. Fixes #22592 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gates the server build capture Vite plugin on the
transformhook'soptions.ssrflag instead ofconfig.build.ssr.options.ssris set for the SSR module in bothreact-router devand production builds, so middleware names now resolve in dev mode too — previously the build-only gate skipped dev entirely.Adds a dev-mode e2e app (
react-router-7-framework-instrumentation-dev) that runsreact-router devand asserts the middleware name resolves from the captured server build. Verified it fails without the fix.Fixes #22592