Skip to content

ref(opentelemetry): Remove unusedwrapClient#22576

Merged
mydea merged 2 commits into
developfrom
fn/otel-client
Jul 24, 2026
Merged

ref(opentelemetry): Remove unusedwrapClient#22576
mydea merged 2 commits into
developfrom
fn/otel-client

Conversation

@mydea

@mydea mydea commented Jul 24, 2026

Copy link
Copy Markdown
Member

This was not used in node actually, we just built this manually there. Eventually this will totally go away (the tracer stuff) but for now this should be one less export.

Comment thread packages/opentelemetry/test/integration/breadcrumbs.test.ts
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 27.79 kB - -
@sentry/browser - with treeshaking flags 26.23 kB - -
@sentry/browser (incl. Tracing) 46.31 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.06 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.12 kB - -
@sentry/browser (incl. Tracing, Replay) 85.59 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.23 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 90.29 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.97 kB - -
@sentry/browser (incl. Feedback) 44.96 kB - -
@sentry/browser (incl. sendFeedback) 32.59 kB - -
@sentry/browser (incl. FeedbackAsync) 37.64 kB - -
@sentry/browser (incl. Metrics) 28.88 kB - -
@sentry/browser (incl. Logs) 29.11 kB - -
@sentry/browser (incl. Metrics & Logs) 29.8 kB - -
@sentry/react 29.59 kB - -
@sentry/react (incl. Tracing) 48.6 kB - -
@sentry/vue 33.22 kB - -
@sentry/vue (incl. Tracing) 48.28 kB - -
@sentry/svelte 27.81 kB - -
CDN Bundle 30.11 kB - -
CDN Bundle (incl. Tracing) 48.14 kB - -
CDN Bundle (incl. Logs, Metrics) 31.69 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.47 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.95 kB - -
CDN Bundle (incl. Tracing, Replay) 85.72 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.01 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.49 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.78 kB - -
CDN Bundle - uncompressed 89.77 kB - -
CDN Bundle (incl. Tracing) - uncompressed 144.84 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.48 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 148.82 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 219.24 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 264.08 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 268.04 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 277.78 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 281.74 kB - -
@sentry/nextjs (client) 51.13 kB - -
@sentry/sveltekit (client) 46.75 kB - -
@sentry/core/server 79.92 kB - -
@sentry/core/browser 51.9 kB - -
@sentry/node 124.53 kB +0.11% +131 B 🔺
@sentry/node (incl. diagnostics channel injection) 168.54 kB +0.08% +127 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B - -
@sentry/node - without tracing 74.8 kB +0.19% +139 B 🔺
@sentry/aws-serverless 84.26 kB +0.16% +130 B 🔺
@sentry/cloudflare (withSentry) - minified 196.61 kB - -
@sentry/cloudflare (withSentry) 483.18 kB - -

View base workflow run

@mydea
mydea marked this pull request as ready for review July 24, 2026 08:04
@mydea
mydea requested a review from a team as a code owner July 24, 2026 08:04
@mydea
mydea requested review from andreiborza and isaacs and removed request for a team July 24, 2026 08:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 950d15a. Configure here.


export { getRequestSpanData } from './utils/getRequestSpanData';

export type { OpenTelemetryClient } from './types';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public API removed without deprecation

Medium Severity

Flagging because it was mentioned in the PR Review Guidelines: the Breaking Changes rules call out removing publicly exported functions or types without a deprecation notice. This drops wrapClientClass and OpenTelemetryClient from the @sentry/opentelemetry public entrypoint with no @deprecated period, unlike wrapContextManagerClass.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 950d15a. Configure here.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--

@mydea
mydea merged commit b5bf632 into develop Jul 24, 2026
423 of 425 checks passed
@mydea
mydea deleted the fn/otel-client branch July 24, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants