feat!: Require Node >=20.19.0 as minimum supported version#22558
Merged
Conversation
Bumps the minimum supported Node.js version to 20.19.0 for v11 and removes now-dead runtime branches that guarded pre-20 Node versions. Ref #22056 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
July 24, 2026 07:22
andreiborza
requested review from
JPeer264,
chargome,
isaacs,
logaretm,
msonnb,
nicohrubec and
timfish
and removed request for
a team
July 24, 2026 07:22
nicohrubec
reviewed
Jul 24, 2026
| * - Dropped the `@opentelemetry/instrumentation` base (undici reports via `diagnostics_channel`, | ||
| * so no module patching was needed) — exposed as a plain `instrumentUndici()` function that the | ||
| * integration wires up directly | ||
| * - Dropped the pre-18.19.0 `diagnostics_channel` ref-counting workaround, since the SDK |
Member
There was a problem hiding this comment.
l: don't think this adds anything?
nicohrubec
approved these changes
Jul 24, 2026
Member
Author
|
I updated the range to |
nicohrubec
approved these changes
Jul 24, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
we also have checks in our orchestrion integration to see if tracing channels are available, which seems to be only relevant for node 18 afaict? e.g. here
Shouldn't hurt to be safe but we could also think about removing these?
| }); | ||
| }); | ||
|
|
||
| describe('createCallbackList', () => { |
Member
There was a problem hiding this comment.
q: why is this no longer relevant?
Member
Author
There was a problem hiding this comment.
createCallbackList was sync only and the code always chooses async by default given the node version so this is no longer needed.
Lms24
approved these changes
Jul 24, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
nice!
q: Should this be feat(node)!: ... ?
Member
Author
|
@nicohrubec that comment is kinda misleading because server-utils can also be used by bun, cf and deno where it's not as clear which versions need it. I opted to keep it for now, we can clean that up later if we are confident it doesn't break. |
Member
Author
|
@Lms24 it kinda touches every sdk package which is why it doesn't have a scope |
chargome
added a commit
that referenced
this pull request
Jul 24, 2026
…e app (#22593) Removes the `react-router-7-framework-spa-node-20-18` e2e app. It existed only to test on Node 20.18, which is now below the `>=20.19.0` minimum supported version (#22558). It is otherwise a duplicate of `react-router-7-framework-spa`, so it is removed rather than kept on an unsupported Node version. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise the minimum supported Node.js version to
20.19.0for v11.engines.nodeto>=20.19.0across all packages and dev-packages.diagnostics_channelrefcount fallbacks, and the redis!dc.tracingChannelfallback.ci-unit-tests.tsand refresh stale Node-18 references (issue template, workflow comment, docs, pino/spotlight docstrings).Why
v11 targets Node
20.19.0so the SDK can rely onrequire(esm)and stabletracingChannelwithout polyfills or legacy code paths. CI matrices, the migration guide, and the volta pin were already moved to Node 20; this aligns the publishedenginesfields and removes the dead code the old floor required.Kept the
>=22.12gates and the cross-runtime!dc.tracingChannelguards in@sentry/server-utils, which are still reachable on Deno/Bun/Cloudflare. The react-router server-OTel path and itsnode-20-18e2e apps are left to #22290, which removes them.Ref #22056