ref(core): Ensure error span status is always valid#22522
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
July 23, 2026 08:01
mydea
requested review from
JPeer264,
Lms24 and
isaacs
and removed request for
a team
July 23, 2026 08:01
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mydea
force-pushed
the
fn/otel-span-status
branch
from
July 24, 2026 07:14
b5b62ef to
60f9673
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 60f9673. Configure here.
| } from '@sentry/core'; | ||
| import type { Span, SpanAttributes } from '@sentry/core'; | ||
| import { inferStatusFromAttributes, isStatusErrorMessageValid } from './utils/mapStatus'; | ||
| import { inferStatusFromAttributes } from './utils/mapStatus'; |
There was a problem hiding this comment.
Unreachable status normalization branch
Low Severity
applyOtelSpanStatus still tries to normalize invalid error messages for non-streaming spans, but it receives spanJSON.status from getStatusMessage, which already always returns a valid value. That makes the isStatusErrorMessageValid check and live setStatus call unreachable leftover after the core change.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 60f9673. Configure here.
Member
Author
There was a problem hiding this comment.
this is fine, we apply a more in-depth normalization here, we do not look at grpc status code in core implementation etc.
Lms24
approved these changes
Jul 24, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Bundle size hit isn't ideal but I don't see an easy way to limit this to server runtimes only. Briefly thought about storing this on the client but then we'd need to get the client for span serialization which is also far from ideal 😅 Also, I think it could theoretically also affect the client-side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some code in otel span serialization that ensures that span statuses are correct. if we remove this layer, however we can "invalid" span statuses (e.g. random error messages etc). This change ensures we always have valid span statuses everywhere, in the legacy transaction mode.