feat(deno): add anthropic integration#22468
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 20:25
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 21, 2026 20:55
fcdda49 to
6581776
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-openai
branch
from
July 21, 2026 20:55
9ea3b80 to
247a3be
Compare
Member
Author
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 21, 2026 21:31
6581776 to
40c51ca
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-openai
branch
from
July 21, 2026 21:31
247a3be to
166b082
Compare
Comment on lines
+69
to
+72
| Deno.test('anthropic instrumentation: orchestrion @anthropic-ai/sdk:chat channel produces a nested gen_ai span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ |
Contributor
There was a problem hiding this comment.
Bug: Deno integration tests fail to reset the global installedIntegrations array, causing subsequent tests in the same file to skip crucial setupOnce() logic and fail.
Severity: MEDIUM
Suggested Fix
Update the resetGlobals() function used in the Deno integration test suites to also clear the installedIntegrations array from @sentry/core. This can be achieved by adding installedIntegrations.splice(0, installedIntegrations.length), ensuring each test runs with a clean integration state and setupOnce() is called correctly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-anthropic/test.ts#L69-L72
Potential issue: The global `installedIntegrations` array is not reset between Deno
integration tests that run within the same file. When the first test initializes an
integration, it adds its name to this array. A subsequent test in the same file will
then skip the integration's `setupOnce()` function because the core `setupIntegration()`
logic sees the integration as already installed. This prevents necessary setup, such as
subscribing to channels, from occurring in the second test, causing it to fail when it
expects behavior configured in `setupOnce()`.
Also affects:
dev-packages/deno-integration-tests/suites/orchestrion-anthropic/test.ts:57~62
Did we get this right? 👍 / 👎 to inform future reviews.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 21, 2026 21:43
40c51ca to
3e3e6d2
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-openai
branch
from
July 21, 2026 21:43
166b082 to
1b4d06d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.