Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
// <reference lib="deno.ns" />

import { tracingChannel } from 'node:diagnostics_channel';
import type { TransactionEvent } from '@sentry/core';
import type { DenoClient } from '@sentry/deno';
import { getCurrentScope, getGlobalScope, getIsolationScope, init, startSpan } from '@sentry/deno';
import { assert } from 'https://deno.land/std@0.212.0/assert/assert.ts';
import { assertExists } from 'https://deno.land/std@0.212.0/assert/assert_exists.ts';
import { assertEquals } from 'https://deno.land/std@0.212.0/assert/assert_equals.ts';

function resetGlobals(): void {
getCurrentScope().clear();
getCurrentScope().setClient(undefined);
getIsolationScope().clear();
getGlobalScope().clear();
}

/** See deno-redis.test.ts — same sink shape, deduped for clarity. */
function transactionSink(): {
beforeSendTransaction: (event: TransactionEvent) => null;
waitFor: (predicate: (event: TransactionEvent) => boolean) => Promise<TransactionEvent>;
} {
const transactions: TransactionEvent[] = [];
const waiters: { predicate: (e: TransactionEvent) => boolean; resolve: (e: TransactionEvent) => void }[] = [];
return {
beforeSendTransaction(event) {
transactions.push(event);
for (let i = waiters.length - 1; i >= 0; i--) {
const w = waiters[i]!;
if (w.predicate(event)) {
waiters.splice(i, 1);
w.resolve(event);
}
}
return null;
},
waitFor(predicate) {
const already = transactions.find(predicate);
if (already) return Promise.resolve(already);
return new Promise<TransactionEvent>(resolve => {
waiters.push({ predicate, resolve });
});
},
};
}

function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
let timer: ReturnType<typeof setTimeout> | undefined;
const timeout = new Promise<T>((_, reject) => {
timer = setTimeout(() => reject(new Error(`Timed out waiting for ${what} after ${ms}ms`)), ms);
});
return Promise.race([p, timeout]).finally(() => {
if (timer !== undefined) clearTimeout(timer);
});
}

Deno.test('firebase instrumentation: included in default integrations (Deno 2.8.0+)', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('Firebase'), `Firebase should be in defaults, got ${names.join(', ')}`);
});

Deno.test('firebase instrumentation: orchestrion @firebase/firestore:add-doc channel produces a nested db span', async () => {
resetGlobals();
const sink = transactionSink();
init({
dsn: 'https://username@domain/123',
tracesSampleRate: 1,
beforeSendTransaction: sink.beforeSendTransaction,
});

const channel = tracingChannel('orchestrion:@firebase/firestore:add-doc');

// The subscriber reads these off the reference: `path` names the span/collection,
// `firestore.app` supplies the namespace and project options, `toJSON().settings`
// the server host (omitted here, so no server.address/port attributes).
const reference = {
path: 'users',
type: 'collection',
firestore: {
app: { name: '[DEFAULT]', options: { projectId: 'demo-project', appId: 'demo-app' } },
toJSON: () => ({ settings: {} }),
},
};
const ctx: Record<string, unknown> = { arguments: [reference] };

startSpan({ name: 'parent', op: 'test' }, () => {
channel.start.runStores(ctx, () => undefined);
channel.end.publish(ctx);
ctx.result = {};
channel.asyncStart.runStores(ctx, () => undefined);
channel.asyncEnd.publish(ctx);
});
Comment thread
cursor[bot] marked this conversation as resolved.

const parent = await withTimeout(
sink.waitFor(t => t.transaction === 'parent'),
5000,
"'parent' transaction",
);

const fsSpan = parent.spans?.find(s => s.op === 'db.query');
assertExists(fsSpan, `expected a db.query child span, got ops: ${parent.spans?.map(s => s.op).join(', ')}`);
assertEquals(fsSpan!.description, 'addDoc users');
assertEquals(fsSpan!.data?.['db.operation.name'], 'addDoc');
assertEquals(fsSpan!.data?.['db.collection.name'], 'users');
assertEquals(fsSpan!.data?.['db.namespace'], '[DEFAULT]');
assertEquals(fsSpan!.data?.['db.system.name'], 'firebase.firestore');
assertEquals(fsSpan!.data?.['firebase.firestore.options.projectId'], 'demo-project');
assertEquals(fsSpan!.data?.['sentry.origin'], 'auto.firebase.orchestrion.firestore');
});
1 change: 1 addition & 0 deletions packages/deno/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export {
awsChannelIntegration,
dataloaderChannelIntegration,
expressChannelIntegration,
firebaseChannelIntegration,
genericPoolChannelIntegration,
graphqlDiagnosticsChannelIntegration,
hapiChannelIntegration,
Expand Down
2 changes: 2 additions & 0 deletions packages/deno/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
amqplibChannelIntegration,
awsChannelIntegration,
expressChannelIntegration,
firebaseChannelIntegration,
genericPoolChannelIntegration,
graphqlDiagnosticsChannelIntegration,
hapiChannelIntegration,
Expand Down Expand Up @@ -89,6 +90,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
amqplibChannelIntegration(),
awsChannelIntegration(),
expressChannelIntegration(),
firebaseChannelIntegration(),
genericPoolChannelIntegration(),
hapiChannelIntegration(),
kafkajsChannelIntegration(),
Expand Down
4 changes: 4 additions & 0 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ snapshot[`captureException 1`] = `
"Amqplib",
"Aws",
"Express",
"Firebase",
"GenericPool",
"Hapi",
"Kafka",
Expand Down Expand Up @@ -210,6 +211,7 @@ snapshot[`captureMessage 1`] = `
"Amqplib",
"Aws",
"Express",
"Firebase",
"GenericPool",
"Hapi",
"Kafka",
Expand Down Expand Up @@ -308,6 +310,7 @@ snapshot[`captureMessage twice 1`] = `
"Amqplib",
"Aws",
"Express",
"Firebase",
"GenericPool",
"Hapi",
"Kafka",
Expand Down Expand Up @@ -413,6 +416,7 @@ snapshot[`captureMessage twice 2`] = `
"Amqplib",
"Aws",
"Express",
"Firebase",
"GenericPool",
"Hapi",
"Kafka",
Expand Down