feat(react-router): Auto-inject server instrumentation via top-level import#22441
Draft
chargome wants to merge 2 commits into
Draft
feat(react-router): Auto-inject server instrumentation via top-level import#22441chargome wants to merge 2 commits into
chargome wants to merge 2 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…njection CodeQL (js/file-system-race) flagged the check-then-use pattern in the auto-inject build hook: `existsSync` was followed later by `readFileSync`/`copyFileSync` on the same paths, leaving a TOCTOU gap where the file could change between check and use. Attempt the read and copy directly inside try/catch instead, removing the prior existence checks. User-facing warnings and skip behavior are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
autoInjectServerInstrumentationbuild option that prepends a top-level import of the server instrumentation file (default./instrument.server.mjs) to the built server entry, so users no longer needNODE_OPTIONS='--import ...'in their start script. A top-level import is sufficient because deep library instrumentation is handled by the orchestrion instrumentation. Defaults tofalsefor now; will defaultto
truein once orchestrion is the default.closes #22413