feat(server-utils): Port Bedrock aws-sdk extension and add integration tests - #22166
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
July 9, 2026 21:44
188ac82 to
ff165d4
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 9, 2026 21:48
ff165d4 to
a4dd353
Compare
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 9, 2026 22:11
a4dd353 to
968db2f
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 9, 2026 22:14
968db2f to
5f2a15f
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 9, 2026 22:31
5f2a15f to
8f3599b
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 9, 2026 22:46
8f3599b to
0a944ab
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 9, 2026 22:55
0a944ab to
5506257
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
July 10, 2026 07:40
14699e8 to
a464258
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
July 10, 2026 14:39
2849cfe to
8e57368
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 10, 2026 14:48
8e57368 to
a265ce7
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
3 times, most recently
from
July 15, 2026 13:05
d096bd6 to
7813fbf
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 15, 2026 13:21
7813fbf to
b26c7d1
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 15, 2026 13:37
b26c7d1 to
87eaf3a
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
July 15, 2026 13:54
db6d0a5 to
86f20c1
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86f20c1. Configure here.
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
2 times, most recently
from
July 15, 2026 14:49
ee60599 to
a94d0e5
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 15, 2026 15:10
a94d0e5 to
4ec2635
Compare
andreiborza
force-pushed
the
ab/aws-sdk-bedrock
branch
from
July 15, 2026 15:18
4ec2635 to
2c0f0f5
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nicohrubec
approved these changes
Jul 16, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
nice, didn't know that we support this already
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the BedrockRuntime gen_ai service extension from the OTel aws-sdk integration to the orchestrion channel integration: chat span name and request parameters for
Converse/ConverseStream, per-model-family request body parsing forInvokeModel/InvokeModelWithResponseStream(titan, nova, claude, llama, cohere, mistral), token usage and finish reasons from responses, and deferred span end for the streaming commands (the span ends when the wrapped stream is consumed).Adds nock-mocked integration tests for the non-streaming
ConverseandInvokeModelcommands, asserted against both the OTel and diagnostics-channel paths. The streaming commands use the AWS binary eventstream framing which nock cannot mock, so they stay untested here.This completes orchestrion parity with the OTel aws-sdk integration.
User-facing differences to the vendored OTel instrumentation
ConverseStreamcallers receive the original response object with itsstreamwrapped in place, instead of a new object (a channel subscriber can't replace the resolved value); relevant only to identity-sensitive codeFixes #20946