Skip to content

test(cloudflare): Unflake integration test #20208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JPeer264 wants to merge 1 commit into
base: develop
Choose a base branch
from
+17 −0
Open

test(cloudflare): Unflake integration test #20208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dev-packages/cloudflare-integration-tests/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ export function createRunner(...paths: string[]) {
`SENTRY_DSN:http://public@localhost:${mockServerPort}/1337`,
'--var',
`SERVER_URL:${serverUrl}`,
'--port',
'0',
'--inspector-port',
'0',
],
{ stdio, signal },
);
Expand Down
10 changes: 10 additions & 0 deletions dev-packages/cloudflare-integration-tests/suites/tracing/durableobject-spans/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,20 @@ it('sends child spans on repeated Durable Object calls', async ({ signal }) => {
// Expect 5 transaction envelopes — one per call.
const runner = createRunner(__dirname).expectN(5, assertDoWorkEnvelope).start(signal);

// Small delay between requests to allow waitUntil to process in wrangler dev.
// This is needed because wrangler dev may not guarantee waitUntil completion
// the same way production Cloudflare does. Without this delay, the last
// envelope's HTTP request may not complete before the test moves on.
const delay = () => new Promise(resolve => setTimeout(resolve, 50));
Copy link
Copy Markdown
Member

@nicohrubec nicohrubec Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: can we solve this differently, specifically is there some event that we could await before moving onto the next request instead of adding a timeout? this might already help but I am worried that this will not fully resolve the flakiness


await runner.makeRequest('get', '/');
await delay();
await runner.makeRequest('get', '/');
await delay();
await runner.makeRequest('get', '/');
await delay();
await runner.makeRequest('get', '/');
await delay();
await runner.makeRequest('get', '/');
await runner.completed();
});
3 changes: 3 additions & 0 deletions dev-packages/cloudflare-integration-tests/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ export default defineConfig({
singleThread: true,
},
},
sequence: {
shuffle: true,
},
reporters: process.env.DEBUG
? ['default', { summary: false }]
: process.env.GITHUB_ACTIONS
Expand Down
Loading