Skip to content

chore(deps): update Gradle to v9.5.1#5419

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
deps/scripts/update-gradle.sh
Open

chore(deps): update Gradle to v9.5.1#5419
github-actions[bot] wants to merge 1 commit into
mainfrom
deps/scripts/update-gradle.sh

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Bumps scripts/update-gradle.sh from v9.5.0 to v9.5.1.

Auto-generated by a dependency updater.

Changelog

Commits between v9.5.0 and v9.5.1

  • Update Documentation Infrastructure: Fix scrolling issue in user manual (#37861)
  • fix scroll
  • Only try to run as worker thread in DefaultBuildOperationQueue (#37845)
  • Release notes for Gradle 9.5.1 (#37853)
  • Release notes for Gradle 9.5.1
  • Address review feedback on worker-lease retry changes
  • Revert enrich file visitor with size info on release branch (#37848)
  • Fix tryRunAsWorkerThread null-return test to match contract
  • Revert "Add getLength() to FilePropertyVisitor.VisitState"
  • Revert "Fix annotation"
  • Revert "Introduce helper method getFileSnapshotLength()"
  • Only try to run as worker thread in DefaultBuildOperationQueue
  • Update DefaultConditionalExecutionQueue note to point to correct class
  • Enrich file visitor with file size info (#37568)
  • Merge branch 'release' into snoopcheri/enrich-file-visitor-with-size-info-release
  • Introduce helper method getFileSnapshotLength()
  • Update Documentation: fix paths in worker_api.adoc (#37826)
  • fix paths in worker_api.adoc
  • Fix exception thrown from BaseDirFileResolver when Tooling API receives a relative project directory (#37762)
  • Fix exception thrown from BaseDirFileResolver when Tooling API receives a relative project directory
  • Fix annotation
  • Add getLength() to FilePropertyVisitor.VisitState
  • Prepare for 9.5.1 (#37799)
  • Prepare for 9.5.1
  • Automate tasks for prepare for patch - cherry-pick of #37214 to release (#37798)
  • Automate tasks for prepare for patch (#37214)
  • Update jdks.yaml (#37781)
  • Update jdks.yaml
  • Update Gradle wrapper to version 9.5.0 (#37725)
  • Update Gradle wrapper to version 9.5.0

@github-actions github-actions Bot requested a review from adinauer as a code owner May 12, 2026 14:33
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label May 12, 2026
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label May 12, 2026
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh branch from 9e0b02d to 5a3e92d Compare May 12, 2026 14:33
Comment thread gradlew.bat
echo location of your Java installation. 1>&2

goto fail
"%COMSPEC%" /c exit 1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In gradlew.bat, using "%COMSPEC%" /c exit 1 fails to terminate the script on Windows when Java is not found, leading to spurious follow-on errors.
Severity: MEDIUM

Suggested Fix

Revert the change from "%COMSPEC%" /c exit 1 back to goto fail. The goto fail command correctly jumps to the :fail label, which then uses exit /b 1 to terminate the batch script with an error code, providing the intended fail-fast behavior.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: gradlew.bat#L54

Potential issue: In `gradlew.bat`, replacing `goto fail` with `"%COMSPEC%" /c exit 1`
fails to terminate the script on Windows when Java is not found. The new command spawns
a child process that exits, but the parent script continues execution. This results in
the script printing an initial error, then incorrectly falling through to other labels,
producing a second spurious error message before attempting to run a non-existent Java
binary. The previous `goto fail` logic correctly terminated the script in these error
conditions.

Did we get this right? 👍 / 👎 to inform future reviews.

@runningcode runningcode reopened this May 12, 2026
@runningcode
Copy link
Copy Markdown
Contributor

@dependabot rebase

@runningcode runningcode reopened this May 12, 2026
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh branch from 5a3e92d to 61cde8a Compare May 12, 2026 16:01
Comment thread gradlew.bat
echo location of your Java installation. 1>&2

goto fail
"%COMSPEC%" /c exit 1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The gradlew.bat script fails to exit properly after a JAVA_HOME error, leading to a confusing secondary error message.
Severity: MEDIUM

Suggested Fix

Replace "%COMSPEC%" /c exit 1 with exit /b 1 to ensure the batch script terminates immediately after reporting the JAVA_HOME error, preventing fall-through to the :execute label.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: gradlew.bat#L68

Potential issue: In `gradlew.bat`, when `JAVA_HOME` is invalid or not set, the script
attempts to exit using `"%COMSPEC%" /c exit 1`. This command only terminates a child
command prompt, not the parent batch script itself. Consequently, execution falls
through to the `:execute` label. This causes a subsequent attempt to run Gradle with an
invalid `%JAVA_EXE%` path, leading to a confusing secondary error message instead of a
clean exit after the initial error report.

@sentry
Copy link
Copy Markdown

sentry Bot commented May 12, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.41.0 (1) release

⚙️ sentry-android Build Distribution Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants