chore(deps): update Cocoa SDK to v9.15.0#5264
Conversation
d8950a2 to
fe04576
Compare
| @@ -1 +1 @@ | |||
| Subproject commit 193d313fbfd9affaf2be1692a0284a3b6574c515 | |||
| Subproject commit cef29e94feb00b1b712514443d6d70b09ef20355 | |||
There was a problem hiding this comment.
Bug: The sentry-cocoa submodule update is not synchronized with the modules/sentry-cocoa.properties file, potentially causing release builds to use an outdated binary.
Severity: MEDIUM
Suggested Fix
The dependency update workflow should be modified to automatically generate or update the modules/sentry-cocoa.properties file with the correct version whenever the sentry-cocoa submodule is updated. This will ensure that builds relying on the properties file download the correct binary version, synchronizing it with the submodule pointer.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: modules/sentry-cocoa#L1
Potential issue: The dependency update process for `sentry-cocoa` only updates the git
submodule pointer but does not update the corresponding
`modules/sentry-cocoa.properties` file. This properties file is used by some build
configurations to download a pre-built binary. Because the file is not updated, these
builds may download and use an outdated version of the `sentry-cocoa` library, leading
to a version mismatch between the source code and the compiled binary. While the current
CI configuration may build from the submodule source, masking this issue, other build
environments or local development setups could fail or use the wrong dependency version.
Did we get this right? 👍 / 👎 to inform future reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5264 +/- ##
=======================================
Coverage 74.09% 74.10%
=======================================
Files 508 508
Lines 18320 18320
Branches 3584 3584
=======================================
+ Hits 13575 13576 +1
+ Misses 3872 3866 -6
- Partials 873 878 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fe04576 to
687ed87
Compare
Bumps modules/sentry-cocoa from 9.14.0 to 9.15.0.
Auto-generated by a dependency updater.
Changelog
9.15.0
Features
SentrySDK.extendAppLaunch()andSentrySDK.finishExtendedAppLaunch()to extend standalone app start spans beyond the default end point (e.g. include initial data loading). CallextendAppLaunch()afterSentrySDK.start(options:)and before the app start transaction is created, then callfinishExtendedAppLaunch()when your app is fully ready. Requiresoptions.experimental.enableStandaloneAppStartTracing = true. (#7936)Fixes