Skip to content

docs(size-analysis): Mark build-configuration as optional #18792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry-junior wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Draft

docs(size-analysis): Mark build-configuration as optional #18792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/product/size-analysis/integrating-into-ci.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ Check that:
- You're correctly uploading builds for size analysis from all base branch builds
- You're correctly uploading builds for size analysis from the PR branch.
- Your builds that you want to compare have the same build configuration (for example, both are `Release` builds)
- Your builds contain all the [required metadata](/product/size-analysis/#upload-metadata)
- Your builds include the expected [upload metadata](/product/size-analysis/#upload-metadata)

### Missing Base Build

Expand Down
2 changes: 1 addition & 1 deletion includes/size-analysis/upload-metadata.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ We use build metadata to organize builds in the UI and ensure correct comparison
| ----------------------- | --------------------------------------------------------------------------------------------------------- |
| `org`\* | Sentry organization slug |
| `project`\* | Sentry project slug |
| `build-configuration`\* | Build configuration describing how the app was built, for example `Release` or `Debug` or `Release-Bazel` |
| `build-configuration` | Build configuration describing how the app was built, for example `Release`, `Debug`, or an Android build variant like `freeRelease`. Recommended so size comparisons stay like-for-like across variants. |
| `head-sha` | Current commit SHA |
| `base-sha` | Base commit SHA (for comparisons, recommended to use the branch's merge-base) |
| `vcs-provider` | VCS provider name (for example `github`, `gitlab`, `bitbucket`, `azure`, `github_enterprise`). If not provided, the provider will be auto-detected from the git remote URL. Note: Only `github` and `github_enterprise` are supported for status checks. |
Expand Down
Loading