docs(SmartLink): Handle clipboard write permission denied error#17854
Draft
sentry[bot] wants to merge 1 commit into
Draft
docs(SmartLink): Handle clipboard write permission denied error#17854sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
*This PR addresses issue DOCS-84P, where a
NotAllowedErrorwas reported whennavigator.clipboard.writeText()failed due to write permission being denied. This typically occurred in environments like Linux or headless Chrome, which accounted for a significant portion of the reported errors.The
SmartLinkcomponent, specifically in itshandleAutolinkClickfunction, attempted to write thelink.hrefto the clipboard when an autolink heading was clicked. This operation was not wrapped in atry/catchblock, leading to unhandled exceptions when the browser denied clipboard write access.To fix this, the
navigator.clipboard.writeText()call has been wrapped in anasynctry/catchblock. This ensures thatNotAllowedErrorexceptions, which are expected behavior in environments where clipboard access is restricted, are silently caught and do not result in unhandled errors being reported to Sentry.*IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Fixes DOCS-84P