Fix snuba-api healthcheck bypassing proxy for local requests - #4441
Open
oddballfr wants to merge 1 commit into
Open
Fix snuba-api healthcheck bypassing proxy for local requests#4441oddballfr wants to merge 1 commit into
oddballfr wants to merge 1 commit into
Conversation
Fix snuba-api healthcheck bypassing proxy for local requests (urllib NO_PROXY doesn't support CIDR ranges)
aldy505
approved these changes
Aug 1, 2026
aminvakil
suggested changes
Aug 1, 2026
aminvakil
left a comment
Collaborator
There was a problem hiding this comment.
I think it's better to set NO_PROXY to 127.0.0.1 and there is no need for this change.
This should be documented in container scope proxy setting in docs though, current docs only say 127.0.0.0/8.
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix snuba-api healthcheck bypassing proxy for local requests (urllib NO_PROXY doesn't support CIDR ranges)
Problem
The snuba-api healthcheck (api_healthcheck.py) was failing in environments with an HTTP(S) proxy configured (HTTP_PROXY/HTTPS_PROXY). Squid logs confirmed the local request was being routed through the proxy and rejected:
TCP_DENIED/403 ... GET http://127.0.0.1:1218/health
Root cause
urllib.request does not support CIDR notation (127.0.0.0/8) in NO_PROXY — it only matches exact hostnames or domain suffixes. A NO_PROXY value that works for curl/wget can therefore still leave this local request routed through the configured proxy.
Fix
self-hosted/snuba/api_healthcheck.py now uses a dedicated urllib.request.build_opener(urllib.request.ProxyHandler({})) opener, explicitly forcing no proxy for this local request instead of relying on NO_PROXY parsing.
Testing
snuba-api healthcheck passes again after container rebuild, in an environment with HTTP_PROXY/HTTPS_PROXY configured.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.