Skip to content

feat(service): Add metrics for multipart upload operations#485

Open
lcian wants to merge 4 commits into
mainfrom
lcian/feat/proper-metrics
Open

feat(service): Add metrics for multipart upload operations#485
lcian wants to merge 4 commits into
mainfrom
lcian/feat/proper-metrics

Conversation

@lcian
Copy link
Copy Markdown
Member

@lcian lcian commented Jun 2, 2026

This adds latency metrics for all multipart operations, all tagged with usecase: multipart.initiate.latency, multipart.upload_part.latency, multipart.list_parts.latency, multipart.abort.latency, and multipart.complete.latency.
Note that these are distributions but we can also chart them as counts/rates to count such requests.
We also track two specific sizes: multipart.upload_part.size and multipart.complete.part_count.

Additionally, we reuse the put.size which we use for normal PUTs to record the size of the assembled object upon multipart_complete.
The reason we reuse that metric is that right now we only use it to create histograms for the size we're storing, so I think it's actually good to have them together.
A new tag upload_type lets us distinguish between the kind of upload that recorded a put.size (direct or multipart).

Close FS-360

@codecov

This comment has been minimized.

@lcian lcian marked this pull request as ready for review June 2, 2026 13:43
@lcian lcian requested a review from a team as a code owner June 2, 2026 13:43
@lcian lcian requested a review from matt-codecov June 2, 2026 13:44
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Jun 2, 2026

FS-360

Comment thread objectstore-service/src/backend/tiered.rs
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 737c745. Configure here.

Comment thread objectstore-service/src/backend/tiered.rs Outdated
Comment thread objectstore-service/src/backend/tiered.rs
Copy link
Copy Markdown
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address robot comments

Comment thread objectstore-service/src/backend/tiered.rs Outdated
Comment thread objectstore-service/src/backend/tiered.rs
Comment thread objectstore-service/src/backend/tiered.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants