feat(service): Add metrics for multipart upload operations#485
Open
lcian wants to merge 4 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 737c745. Configure here.
matt-codecov
approved these changes
Jun 5, 2026
Contributor
matt-codecov
left a comment
There was a problem hiding this comment.
address robot comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds latency metrics for all multipart operations, all tagged with
usecase:multipart.initiate.latency,multipart.upload_part.latency,multipart.list_parts.latency,multipart.abort.latency, andmultipart.complete.latency.Note that these are distributions but we can also chart them as counts/rates to count such requests.
We also track two specific sizes:
multipart.upload_part.sizeandmultipart.complete.part_count.Additionally, we reuse the
put.sizewhich we use for normal PUTs to record the size of the assembled object uponmultipart_complete.The reason we reuse that metric is that right now we only use it to create histograms for the size we're storing, so I think it's actually good to have them together.
A new tag
upload_typelets us distinguish between the kind of upload that recorded aput.size(directormultipart).Close FS-360