feat(incidents): Set channel topic on status channels#243
Open
rgibert wants to merge 10 commits into
Open
Conversation
Status channels were created without a topic, while the main incident channel always had one set. Now the status channel gets the same topic as the main channel at creation time and whenever the topic-relevant fields (title, severity, captain) change. Co-Authored-By: Claude <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/AvmWtSfOOeXg5PYEsqE2lSHWXgDXqqOQpUbwYuyXvng
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…ions Wrap status channel set_channel_topic calls in their own try/except blocks in on_severity_changed, on_title_changed, and on_captain_changed so a failure does not skip subsequent message posting or user invites. Co-Authored-By: Claude <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/sbcLyL6uXbXaI0a1CGpm4p26nvdj-LI_WJ1J6FNVDSQ
…h try/except An unhandled exception from _get_status_channel_id would halt the rest of on_incident_updated, skipping notifications, slack dumps, and severity escalation handling. Co-Authored-By: Claude <noreply@anthropic.com>
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
…_incident_updated The refactor inadvertently moved build_channel_topic outside the try/except block, meaning a failure in topic construction would propagate uncaught and abort the rest of on_incident_updated. Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ch other In on_severity_changed and on_title_changed, a failure setting the main channel topic no longer skips the status channel update. In on_incident_updated, build_channel_topic is now separated from the set_channel_topic call so a Slack API failure does not discard the already-built topic and skip the status channel update. Co-Authored-By: Claude <noreply@anthropic.com>
Wrap set_channel_topic for the main channel in its own try/except so a failure does not skip posting the captain update message or inviting the new captain to the channel. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a641bf4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update topic updates to parallel update the topic for #inc-xxxx and #inc-xxxx-status channels.