Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Init
Resolve
Upgrade
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
BYK
force-pushed
the
fix/issue-list-query-auto-correct
branch
from
8bc5abf to
f1cd984
Compare
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1632 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.27% 95.26% -0.01%
==========================================
Files 234 234 —
Lines 34386 34442 +56
Branches 0 0 —
==========================================
+ Hits 32761 32810 +49
- Misses 1625 1632 +7
- Partials 0 0 —Generated by Codecov Action |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f1cd984. Configure here.
BYK
force-pushed
the
fix/issue-list-query-auto-correct
branch
from
3ac2c4d to
56b4b12
Compare
…d JSON syntax reference - Document Sentry search syntax in --query flag help text and fullDescription: implicit AND, no OR/AND operators, alternatives (in-list key:[val1,val2], wildcards), common filters, docs link - Make AND/OR detection case-insensitive (token.toUpperCase()) to match the PEG grammar's 'OR'i / 'AND'i rules - Add SEARCH_SYNTAX_REFERENCE object to --json output envelope as _searchSyntax field — gives agents machine-readable query capabilities - Add code references to Sentry's parser implementations: - PEG grammar: getsentry/sentry grammar.pegjs (Peggy frontend) - Backend tokenizer: search/utils.py split_query_into_tokens - Notes on equivalence and future work (full PEG port if needed) - Add search syntax examples to docs/fragments/commands/issue.md - Add in-list syntax (key:[val1,val2]) to OR ValidationError alternatives
Address Cursor Bugbot: the old JSDoc that documented the removed jsonTransformIssueList alias was left orphaned above the new constant.
Avoids bloating every successful --json response with static metadata. The syntax reference is most useful when a query returned zero results — likely a syntax issue — so agents and users get help exactly when needed.
BYK
force-pushed
the
fix/issue-list-query-auto-correct
branch
from
95b6c03 to
89017a5
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #727 — three improvements to issue list query handling.
1. Search syntax documentation
fullDescriptionhelp text: implicit AND, no OR/AND, alternatives, common filters, docs link--queryflag brief to mention key constraints upfrontdocs/src/fragments/commands/issue.md2. Case-insensitive AND/OR detection
token === "OR"totoken.toUpperCase() === "OR"to match the PEG grammar's"OR"i/"AND"irulesOr,or,And,andvariants3. JSON search syntax reference (easter egg for agents)
--jsonoutput envelope now includes_searchSyntaxwith machine-readable query capabilities: supported operators, filter types, common filters, and links to PEG grammar source4. Code references for future work
split_query_into_tokensVerification
Our tokenizer regex
(?:[^\s"]*"[^"]*"[^\s"]*)|[^\s]+is functionally equivalent tosplit_query_into_tokens()insrc/sentry/search/utils.pyfor the purpose of detecting standalone boolean operators. Minor differences (single quotes, colon-space joining, escaped quotes) don't affect AND/OR detection.