fix(alert): guard against undefined conditions/actions in list command - #1313
Open
sentry[bot] wants to merge 1 commit into
Open
fix(alert): guard against undefined conditions/actions in list command#1313sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 5485 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.75% 81.75% —%
==========================================
Files 430 430 —
Lines 30063 30063 —
Branches 19707 19711 +4
==========================================
+ Hits 24578 24578 —
- Misses 5485 5485 —
- Partials 2043 2043 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses CLI-2CA, a TypeError occurring in the
sentry alert issues listcommand.The error "TypeError: Cannot read properties of undefined (reading 'length')" was triggered when
r.conditionsorr.actionswereundefinedin the alert rule object returned by the Sentry API. The code atsrc/commands/alert/issues/list.tslines 478-479 was directly accessing.lengthon these potentially undefined properties.The fix involves adding optional chaining (
?.) and nullish coalescing (?? 0) to safely handle cases whereconditionsoractionsmight beundefined, ensuring thatString(undefined.length)is avoided and0is used instead.Fixes CLI-2CA
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.