Generic::to_*() enhancements#672
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the conversion helper functions in include/rfl/Generic.hpp by passing the variant value by const reference (const auto&) instead of by value within the std::visit lambdas. The review feedback suggests a further improvement: replacing std::visit with std::get_if across these functions. This change would avoid the compilation and runtime overhead of instantiating generic lambdas for all variant types, leading to cleaner and more efficient code.
- The new version avoids extra copies in case the current Generic contents do not match the casted-to type. - Using std::get_if avoids switch-case generation for all the variant types when we are only interested in one or two types.
kone-tlammi
changed the title
Contributor
|
@kone-tlammi , thanks for the contribution! I am merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contents do not match the casted-to type.
when we are only interested in one or two types.