Skip to content

Consolidate and validate Dependabot updates #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosriady merged 7 commits into from
Aug 11, 2026
Merged

Consolidate and validate Dependabot updates #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
57be582
Consolidate Dependabot updates
yosriady Aug 11, 2026
da8017d
Run Angular CI on Node 24
yosriady Aug 11, 2026
79a18f1
Pin Angular CI to Node 24.18
yosriady Aug 11, 2026
ed6e498
Fix runtime dependency initialization
yosriady Aug 11, 2026
646d75c
Address PR review feedback
yosriady Aug 11, 2026
e368d48
Restore MetaMask SDK connector
yosriady Aug 11, 2026
b61248a
Address follow-up review feedback
yosriady Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
matrix: ${{ steps.set.outputs.matrix }}
any: ${{ steps.set.outputs.any }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: dorny/paths-filter@d1c1ffe0248fe513906c8e24db8ea791d46f8590 # v3.0.3
- uses: dorny/paths-filter@ceb8a2b8f2d89434be7ff52d3de7ec3738c5cc9d # v4.0.3
id: filter
with:
# Each key maps to a path pattern. Workflow-file changes rebuild all.
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
{"name":"with-web3-onboard","dir":"with-web3-onboard","pm":"pnpm","build":"build","node":"22"},
{"name":"with-react-native","dir":"with-react-native","pm":"pnpm","build":"typecheck","node":"22","audit":"critical"},
{"name":"with-solana","dir":"with-solana","pm":"pnpm","build":"build","node":"22"},
{"name":"with-angular","dir":"with-angular","pm":"pnpm","build":"build","node":"22"},
{"name":"with-angular","dir":"with-angular","pm":"pnpm","build":"build","node":"24.18.0"},
{"name":"with-crossmint","dir":"with-crossmint","pm":"pnpm","build":"build","node":"22","audit":"critical"},
{"name":"with-openfort","dir":"with-openfort/frontend","pm":"pnpm","build":"build","node":"22"},
{"name":"with-turnkey","dir":"with-turnkey","pm":"pnpm","build":"build","node":"22"}
Expand All @@ -126,17 +126,17 @@ jobs:
matrix: ${{ fromJSON(needs.changes.outputs.matrix) }}
name: ${{ matrix.name }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: ${{ matrix.node }}

- name: Install pnpm
if: matrix.pm == 'pnpm'
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10
with:
version: 11

Expand Down Expand Up @@ -210,17 +210,17 @@ jobs:
matrix: ${{ fromJSON(needs.changes.outputs.matrix) }}
name: audit (${{ matrix.name }})
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: ${{ matrix.node }}

- name: Install pnpm
if: matrix.pm == 'pnpm'
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10
with:
version: 11

Expand Down
4 changes: 2 additions & 2 deletions with-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
"buffer": "^6.0.3",
"rxjs": "~7.8.2",
"tslib": "^2.8.1",
"viem": "^2.55.8"
"viem": "^2.55.10"
},
"devDependencies": {
"@angular/build": "^21.2.19",
"@angular/cli": "^21.2.19",
"@angular/compiler-cli": "^21.2.19",
"@ngx-env/builder": "^21.0.1",
"jsdom": "^28.1.0",
"jsdom": "^30.0.1",
"prettier": "^3.9.6",
"typescript": "~5.9.3",
"vitest": "^4.1.10"
Expand Down
196 changes: 92 additions & 104 deletions with-angular/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions with-angular/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ minimumReleaseAgeExclude:
- '@hono/node-server@2.0.5'
# Security: force patched transitive versions (CVE remediation).
overrides:
nanoid@<3.3.17: 3.3.17
shell-quote@<=1.8.4: 1.10.0
'fast-uri@>=3.0.0 <3.1.5': 3.1.5
'fast-uri@>=4.0.0 <4.1.2': 4.1.2
# ws <8.21.0: memory-exhaustion DoS (GHSA-96hv-2xvq-fx4p), pulled in via viem.
'@hono/node-server@<2.0.5': ^2.0.5
brace-expansion@>=2.0.0 <2.1.3: ^2.1.3
Expand Down
2 changes: 1 addition & 1 deletion with-crossmint/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Compare this with [`with-openfort`](../with-openfort) and [`with-privy`](../with

## Tech Stack

- [Next.js 15](https://nextjs.org/) (App Router) + [React 19](https://react.dev/)
- [Next.js 16](https://nextjs.org/) (App Router) + [React 19](https://react.dev/)
- [TypeScript](https://www.typescriptlang.org/) + [Tailwind CSS](https://tailwindcss.com/)
- [@crossmint/client-sdk-react-ui](https://docs.crossmint.com/wallets/quickstarts/react) — embedded wallets
- [@formo/analytics](https://docs.formo.so/) — web3 analytics
Expand Down
9 changes: 9 additions & 0 deletions with-crossmint/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { defineConfig, globalIgnores } from "eslint/config";
import nextVitals from "eslint-config-next/core-web-vitals";
import nextTypescript from "eslint-config-next/typescript";

export default defineConfig([
...nextVitals,
...nextTypescript,
globalIgnores([".next/**", "out/**", "build/**", "next-env.d.ts"]),
]);
14 changes: 8 additions & 6 deletions with-crossmint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
"packageManager": "pnpm@11.1.2",
"scripts": {
"dev": "next dev --turbopack",
"build": "next build",
"build": "next build --webpack",
"start": "next start",
"lint": "next lint"
"lint": "eslint ."
},
"dependencies": {
"@crossmint/client-sdk-react-ui": "4.2.0",
"@formo/analytics": "^1.35.0",
"clsx": "^2.1.1",
"next": "^15.5.22",
"next": "^16.3.0",

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the removed Next.js lint command

After this upgrade, with-crossmint's existing lint script still runs next lint; the same mismatch exists in the newly upgraded with-privy, with-thirdweb, and with-turnkey examples. The Next.js 16 migration guide states that next lint was removed in favor of invoking ESLint or Biome directly, so pnpm lint now exits with an unknown-command error in each of these examples.

Useful? React with 👍 / 👎.

Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

@cubic-dev-ai cubic-dev-ai Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This migration moves the example to Next.js 16, but the workspace README still documents it as 'a Next.js 15 (App Router) + React 19... project'. Update the README's target-stack description to Next 16 so the documented compatibility notes match the bumped dependency.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At with-crossmint/package.json, line 16:

<comment>This migration moves the example to Next.js 16, but the workspace README still documents it as 'a Next.js 15 (App Router) + React 19... project'. Update the README's target-stack description to Next 16 so the documented compatibility notes match the bumped dependency.</comment>

<file context>
@@ -5,15 +5,15 @@
     "@formo/analytics": "^1.35.0",
     "clsx": "^2.1.1",
-    "next": "^15.5.22",
+    "next": "^16.3.0",
     "react": "^19.2.8",
     "react-dom": "^19.2.8",
</file context>

"react": "^19.2.8",
"react-dom": "^19.2.8",
"react-transition-group": "^4.4.5",
Expand All @@ -22,10 +22,12 @@
},
"devDependencies": {
"@tailwindcss/postcss": "^4.3.3",
"@types/node": "^20.19.43",
"@types/react": "^19.2.17",
"@types/react-dom": "^19.2.3",
"@types/node": "^26.1.2",
"@types/react": "^19.2.18",
"@types/react-dom": "^19.2.4",
"@types/react-transition-group": "^4.4.12",
"eslint": "^9.39.5",
"eslint-config-next": "^16.3.0",
"tailwindcss": "^4.3.3",
"typescript": "^5.9.3"
}
Expand Down
Loading