Fix the charts live test for the summaries-default list contract - #46
Merged
Conversation
The old assertion expected the parent board on a default list; it kept passing only while prod still executed charts on list. With the backend trim deployed, the default is summaries (no board, no query/results) and results=true is the opt-in that carries the board — assert both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release PR (#45) merged while its test job was red: the charts live test still asserted the pre-trim response shape (parent
boardon a default list). With formono#2182 deployed, the default list returns summaries, so the assertion fails against the live API and main's CI is red.This is the fix that was pushed to the release branch two minutes after the merge: assert the new contract instead — default list has no
boardand no per-chartquery/results;results=trueis the opt-in that executes charts and carries the board.Verified against production with a live token: 191 passing / 1 pending (the healthy split).
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.