Skip to content

#12743 Add support for Fragment response in GetFeatureInfo - #12744

Open
Binabh wants to merge 2 commits into
geosolutions-it:masterfrom
Binabh:fix/fragment-info
Open

#12743 Add support for Fragment response in GetFeatureInfo #12744
Binabh wants to merge 2 commits into
geosolutions-it:masterfrom
Binabh:fix/fragment-info

Conversation

@Binabh

@Binabh Binabh commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes for case when GetFeatureInfo sends fragment response

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#12743

What is the new behavior?
Fragment response from GetFeatureInfo are properly shown

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@Binabh Binabh added this to the 2026.02.01 milestone Jul 28, 2026
@Binabh
Binabh requested a review from allyoucanmap July 28, 2026 07:25
@cla-bot cla-bot Bot added the CLA Ready label Jul 28, 2026
@Binabh Binabh linked an issue Jul 28, 2026 that may be closed by this pull request
1 task
@allyoucanmap
allyoucanmap requested review from stefanocudini and removed request for allyoucanmap July 29, 2026 08:56
@stefanocudini

Copy link
Copy Markdown
Member

dear @Binabh

I checked the code and the unitetests are fine when displaying the identify content in HTML.

But there's a strange precision issue with the click identify.
It's very difficult to center any value for the lizmap layer (mentioned in the linked issue #12743).
At a quick glance, there doesn't appear to be anything in this PR that could cause this bug, but it's replicable in this branch.
Below are the identify attempts; some work, but they're few.

Peek.2026-08-06.15-49.mp4

@Binabh

Binabh commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@stefanocudini Thank you for your review. Yes this is pretty annoying and I also faced this.

This seems to be issue with Lizmap threshold set using Lizmap QGIS plugin as seen here on page 57.

I also tried to host lizmap project locally as that would give us control over tolerance value but it was very difficult to get the setup right for me.
Looks like for this demo server threshold is set to 0 or very low value.

@stefanocudini

stefanocudini commented Aug 6, 2026

Copy link
Copy Markdown
Member

@stefanocudiniGrazie per la tua recensione. Sì, è davvero fastidioso e anche io ho riscontrato lo stesso problema.

Sembra che il problema riguardi la soglia di Lizmap impostata tramite il plugin Lizmap per QGIS, come si può vedere a pagina 57.

Ho anche provato a ospitare il progetto lizmap in locale, dato che ciò ci avrebbe permesso di controllare il valore di tolleranza, ma è stato molto difficile configurarlo correttamente. Sembra che per questo server demo la soglia sia impostata a 0 o a un valore molto basso.

mmmh I understood, I actually tried to check the request and the bbox is quite large.
request=GetFeatureInfo&BBOX=-8185522.098096532,4993112.772247052,-8184557.080614566,4994077.789729018
about: 1km

I just saw the next PR: #12736
So this one can't solve this either. Is the problem confined to the specific Lizmap server-side right?

@Binabh

Binabh commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@stefanocudini Yes, My understanding here is that it is related to Lizmap config rather than Mapstore2.
#12736 This solves different case when two layers are present.

@stefanocudini

Copy link
Copy Markdown
Member

@stefanocudini Yes, My understanding here is that it is related to Lizmap config rather than Mapstore2. #12736 This solves different case when two layers are present.

ok, please @Binabh check the align with master there seem to be some conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Fragment response in GetFeatureInfo

3 participants