Align LDAP security config with db (Spring 7 follow-up) - #12732
Open
offtherailz wants to merge 1 commit into
Open
Align LDAP security config with db (Spring 7 follow-up)#12732offtherailz wants to merge 1 commit into
offtherailz wants to merge 1 commit into
Conversation
…r init Mirror the db security config on the ldap variants: name the authentication-manager (alias + authentication-manager-ref on http), and mark geoStoreUserServiceAuthenticationProvider lazy-init with depends-on=entityManager. Same treatment geosolutions-it#12428 applied to the db configs but missed on ldap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #12729. The Spring 7 upgrade (#12428) reworked both the db and ldap security configurations, but some of the wiring it added to the db configs was not mirrored on the ldap ones. This aligns the ldap security configuration with the db version.
Two changes, both already present in
geostore-spring-security-db.xml:alias="authenticationManager"on<security:authentication-manager>andauthentication-manager-ref="authenticationManager"on<security:http>.geoStoreUserServiceAuthenticationProviderwithlazy-init="true"anddepends-on="entityManager", so it follows the same init order as in the db config.Applied to both ldap config copies:
product/config/ldap/geostore-spring-security-ldap.xml(used by the product WAR)web/src/config/ldap/geostore-spring-security-ldap.xmlTesting
Built the product with the
ldapprofile and ran it against the acme-ldap test server from the LDAP documentation.bill/helloreturns the ADMIN role,bob/secretreturns USER, and a wrong password returns 401.Related to #12025.