fix: normalize trailing slash in root URL (#2361)#2379
Closed
C1-BA-B1-F3 wants to merge 3 commits into
Closed
Conversation
Root URL links in landing page, collections, and item endpoints were constructed as `base_url?f=json` without a slash before the query string. When users configure a URL with a trailing slash (e.g., `http://localhost:5000/somepath/api/`), the generated URLs would incorrectly omit the slash (e.g., `http://localhost:5000/somepath/api?f=json`). Changed root URL link construction to always include a '/' before the query string, producing correct URLs like `http://localhost:5000/somepath/api/?f=json`.
Contributor
|
This is one of the known incompatibilities between stac and ogcapi, stac is a browsable folder structure, so expects slashes, ogcapi is an api without slashes |
Member
|
Agree @pvgenuchten this is a longstanding discussion upstream of pygeoapi. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2361
Root URL links in landing page, collections, and item endpoints were constructed as
base_url?f=jsonwithout a slash before the query string. When users configure a URL with a trailing slash (e.g.,http://localhost:5000/somepath/api/), the generated URLs would incorrectly omit the slash (e.g.,http://localhost:5000/somepath/api?f=json).Changed root URL link construction to always include a
/before the query string, producing correct URLs likehttp://localhost:5000/somepath/api/?f=json.