[ENH] Introduce FiniteFault model with validation, serialization, and spline taper support - #91
Draft
Leguark wants to merge 1 commit into
Draft
Conversation
…nd spline taper support Adds a Pydantic-based `FiniteFault` dataclass to define finite faults with validated, JSON-serializable fields. Supports cubic, quadratic, and spline tapers, with validation for radii, rotation, and spline control points. Refactors slip calculation logic to use `FiniteFault` and centralizes controls for consistency. Includes tests for serialization, validation, and taper configurations, along with updated documentation.
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 27, 2026
[FIX] Ensure tensors consistently move to backend device and add tests for GPU-specific behavior
#90
Draft
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Pydantic-based
FiniteFaultdataclass to define finite faults with validated, JSON-serializable fields. Supports cubic, quadratic, and spline tapers, with validation for radii, rotation, and spline control points. Refactors slip calculation logic to useFiniteFaultand centralizes controls for consistency. Includes tests for serialization, validation, and taper configurations, along with updated documentation.