Don't allow invalid interpolations to occur#1925
Open
Rangi42 wants to merge 1 commit intogbdev:masterfrom
Open
Don't allow invalid interpolations to occur#1925Rangi42 wants to merge 1 commit intogbdev:masterfrom
Rangi42 wants to merge 1 commit intogbdev:masterfrom
Conversation
Rangi42
added
bug
ISSOtm
requested changes
Apr 10, 2026
Comment on lines
+1343
to
+1344
| // Don't allow invalidly formatted interpolation to occur | ||
| skipChars([&endsEarly](int d) { return d != '}' && !endsEarly(d); }); |
Member
There was a problem hiding this comment.
Bad idea, this fails to take into account nesting, or any other special cases we might introduce. Better let the interpolation be processed normally, and only check the format's validity when that's done.
| error("Missing '}'"); | ||
| break; | ||
| } else if (int c = peek(); endsEarly(c)) { | ||
| error("Unterminated interpolation"); |
Member
There was a problem hiding this comment.
This explains the cause better, but not the symptom. Idk which is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1921