Conversation
Patabugen
marked this pull request as draft
September 14, 2026 14:19
Patabugen
marked this pull request as ready for review
September 14, 2026 14:31
Patabugen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The asyncCaptureLimit and asyncCompareLimits are hardware-dependant, and it would be useful to be able to set/override them per-environment rather than having to share them across all environments.
This PR adds support for setting environment variables which can be read to override backstop.json details.
I implemented it as getEnvironmentDetails so it can be easily expanded to other settings in future.
Docker
The environment variables need to be passed into the docker container, so I've made
runDocker.jsinject any that start withBACKSTOP_.And I've added an
{envs}placeholder so the user can use that if they override thedockerCommandTemplate