Fix 29 socle types recorded with a rank one too high - #70
Open
fingolfin wants to merge 1 commit into
Open
Conversation
PrimitiveGroup(4095,1) is the clearest: it claimed C(7,2), that is Sp(14,2), where the socle is B(6,2) acting on the 4095 non-zero vectors of GF(2)^12. Twenty-nine entries in degrees 3159 to 4095 have the same fault. Only the recorded label is wrong; the groups are untouched. SocleTypePrimitiveGroup computes the corrected value for every one of them, which is what the test checks. Some corrections change the series letter too, C to B. That is harmless where the two names denote the same group -- Omega(2n+1,q) and PSp(2n,q) are isomorphic -- and the rank never was. COHORTS_PRIMITIVE_GROUPS needs no change: it stops at degree 2499, and every correction here is at 3159 or above. Found by comparing every entry field by field against the data-compression branch, which already carries these corrections. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 46 46
Lines 383081 383081
=======================================
Hits 382745 382745
Misses 336 336
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrimitiveGroup(4095,1)is the clearest: it claimed C(7,2), that is Sp(14,2), where the socle is B(6,2) acting on the 4095 non-zero vectors of GF(2)^12. Twenty-nine entries in degrees 3159 to 4095 have the same fault.Only the recorded label is wrong; the groups are untouched.
SocleTypePrimitiveGroupcomputes the corrected value for every one of them, which is what the test checks.Some corrections change the series letter too, C to B. That is harmless where the two names denote the same group: e.g. Omega(2n+1,q) and PSp(2n,q) are isomorphic.
Prepared with AI assistance (Claude).
CC @olexandr-konovalov