Rewrite the data files in a compact format - #69
Draft
fingolfin wants to merge 1 commit into
Draft
Conversation
Three changes to how data/gps*.g is written, none to what it says:
- matrices over the prime field GF(p) become integer matrices scaled once
by Z(p)^0, instead of spelling out 0*Z(p) and Z(p)^k per entry. This also
collapses the two conventions previously in use, Z(q)^k in gps1-24 and
k*Z(p)^0 in gps25-39.
- A_n, S_n, PSL(2,q) and PGL(2,q) in their natural actions are named with
PGAlt, PGSym, PGPsl and PGPgl rather than repeated in full: 9294 of the
24558 entries. Those fields can no longer drift apart, which is how the
socle types of the natural A_n and S_n came to be wrong above degree 2500.
The five entries in degrees 2, 3 and 4 where A_n and S_n really are affine
are still written out, and the writer only uses the short form where it
agrees with the stored entry in every field.
- no indentation, one entry per line. That also removes the backslash-split
string literals, which no line-based tool could read.
40781766 -> 32080459 bytes, 14025491 -> 12922412 gzipped.
Verified by reading every degree from the old files and the new ones into two
copies of PRIMGRP and comparing: no difference in any of the 4094 degrees.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fingolfin
marked this pull request as draft
August 18, 2026 15:44
Member
Author
|
This has some more potential for savings, will follow-up. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
===========================================
- Coverage 99.91% 99.12% -0.80%
===========================================
Files 46 46
Lines 383081 38189 -344892
===========================================
- Hits 382745 37853 -344892
Misses 336 336
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to how
data/gps*.gis written, none to what it says:matrices over the prime field
GF(p)become integer matrices scaled once by Z(p)^0, instead of spelling out0*Z(p)andZ(p)^kper entry. This also collapses the two conventions previously in use,Z(q)^kin gps1-24 andk*Z(p)^0in gps25-39.A_n, S_n, PSL(2,q) and PGL(2,q) in their natural actions are named with PGAlt, PGSym, PGPsl and PGPgl rather than repeated in full: 9294 of the 24558 entries. Those fields can no longer drift apart, which is how the socle types of the natural A_n and S_n came to be wrong above degree 2500. The five entries in degrees 2, 3 and 4 where A_n and S_n really are affine are still written out, and the writer only uses the short form where it agrees with the stored entry in every field. This is partial progress towards issue Replace natural A(n) and S(n) by special placeholders in data files #53.
no indentation, one entry per line. That also removes the backslash-split string literals, which no line-based tool could read.
This shrinks the data: 40781766 -> 32080459 bytes, 14025491 -> 12922412 gzipped.
Verified by reading every degree from the old files and the new ones into two copies of PRIMGRP and comparing: no difference in any of the 4094 degrees.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com